Subject: Re: [PATCH] i2c-ibm_iic driver - new patch

From: Scott Wood <[email-masked]>
Date: Tue, 8 Jan 2008 10:40:44 -0600

On Tue, Jan 08, 2008 at 12:56:27AM -0500, Sean MacLennan wrote:
> Stephen Rothwell wrote:
> > On Mon, 07 Jan 2008 21:03:12 -0500 Sean MacLennan <[email-masked]> wrote:
> >> +static int __devinit iic_probe(struct of_device *ofdev,
> >> +							   const struct of_device_id *match)
> >>     
> >
> > Indenting could be better.
> >   
> Sorry. Since this kernel is in a "work" directory and not in 
> /usr/src/linux* my rules for deciding on the tab size didn't work :( I 
> tried to correct the tabbing.

Better to tab to the semantic indentation level (in this case there is
none), and then use spaces to align -- that way it looks right regardless of
what the tab size is set to.

-Scott