Subject: Re: [PATCH 3/7] Basic Freescale MPC512x support

From: Arnd Bergmann <[email-masked]>
Date: Tue, 8 Jan 2008 19:13:22 +0100

On Tuesday 08 January 2008, Olof Johansson wrote:
> > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> > index 66a3d8c..81c3f05 100644
> > --- a/arch/powerpc/Kconfig
> > +++ b/arch/powerpc/Kconfig
> > @@ -470,7 +470,7 @@ config PCI
> >       bool "PCI support" if 40x || CPM2 || PPC_83xx || PPC_85xx || PPC_86xx \
> >               || PPC_MPC52xx || (EMBEDDED && (PPC_PSERIES || PPC_ISERIES)) \
> >               || PPC_PS3
> > -     default y if !40x && !CPM2 && !8xx && !PPC_83xx \
> > +     default y if !40x && !CPM2 && !8xx && !PPC_512x && !PPC_83xx \
> >               && !PPC_85xx && !PPC_86xx
> 
> This is getting out of control. Not a comment to this specific patch,
> but it's getting silly.
> 
> Btw, why no PCI by default on this platform when it seemingly is default
> on 5200? I thought they were fairly similar.
> 

Just an idea how to restructure this, you could have

config PCI_POSSIBLE
	bool
	help
	  select this from your platform if it can support PCI.

config PCI_DEFAULT
	bool
	select
	help
	  select this from your platform if you want PCI on by default

config PCI
	bool "PCI support"
	depends on PCI_POSSIBLE || PCI_DEFAULT
	default PCI_DEFAULT

config 40x
	# there could be PCI, but normally there isn't
	select PCI_POSSIBLE
	
config PPC_83xx 
	# PCI is normally wanted on 83xx, but you can disable it
	select PCI_DEFAULT

config CHRP
	# CHRP can only be built correctly when PCI is enabled
	select PCI

	Arnd <><