Subject: Re: [PATCH 4/7] Device tree for MPC5121 ADS

From: Scott Wood <[email-masked]>
Date: Tue, 8 Jan 2008 13:22:23 -0600

On Tue, Jan 08, 2008 at 09:01:30AM -0700, John Rigby wrote:
> +	cpld@82000000 {
> +		device_type = "board-control";
> +		reg = <82000000 8000>;
> +	};

Should be:

baord-control@82000000 {
	compatible = "fsl,mpc5121ads-cpld";
	reg = <82000000 8000>;
};

> +		ref-frequency = <3ef1480>;	// 66MHz ref
> +		bus-frequency = <5e69ec0>;	// 99MHz ips ref

Please specify these in decimal rather than hex (using the d# prefix, or
better yet /dts-v1/).

> +		// IPIC
> +		// interrupts cell = <intr #, sense>
> +		// sense values match linux IORESOURCE_IRQ_* defines:
> +		// sense == 8: Level, low assertion
> +		// sense == 2: Edge, high-to-low change
> +		//
> +		ipic: pic@c00 {
> +			interrupt-controller;
> +			#address-cells = <0>;
> +			#interrupt-cells = <2>;
> +			reg = <c00 100>;
> +			built-in;
> +			device_type = "ipic";
> +		};

Remove built-in.

-Scott