Subject: Re: [PATCH 3/7] Basic Freescale MPC512x support

From: Scott Wood <[email-masked]>
Date: Tue, 8 Jan 2008 13:25:31 -0600

On Tue, Jan 08, 2008 at 10:56:41AM -0700, Grant Likely wrote:
> On 1/8/08, Scott Wood <[email-masked]> wrote:
> > On Tue, Jan 08, 2008 at 10:19:20AM -0700, Grant Likely wrote:
> > > > +config MPC5121_ADS
> > > > +       bool "Freescale MPC5121E ADS"
> > > > +       select DEFAULT_UIMAGE
> > > > +       help
> > > > +         This option enables support for the MPC5121E ADS board.
> > >
> > > Make this depend on PPC_MULTIPLATFORM and PPC32
> >
> > I don't think PPC_MULTIPLATFORM is appropriate here... it seems to be
> > OF-specific.
> 
> 52xx is multiplatform.

"multiplatform" and "PPC_MULTIPLATFORM" are not the same.  The config option
is misnamed.

> It works well on both OF and non-OF boards.

It may work, but it pulls in code like prom_init.c that is not needed on
non-OF boards.  It's also quite confusing to have an embedded board's
checkbox only show up when you say yes to "Generic desktop/server/laptop".

-Scott