From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org
Cc: linuxppc-embedded@ozlabs•org
Subject: Re: Generic MMC-over-SPI binding?
Date: Wed, 9 Jan 2008 22:55:31 +0100 [thread overview]
Message-ID: <200801092255.32056.arnd@arndb.de> (raw)
In-Reply-To: <478501A2.60506@hogyros.de>
On Wednesday 09 January 2008, Simon Richter wrote:
> > The important part where this connects to the mmc-spi driver is that
> > you need to set spi_board_info->modalias to "mmc-spi", if the
> > device node can be identified as an mmc card.
>
> Doing that now, using the code you provided as a base. The SPI child
> device gets registered, but it appears something is still missing as no
> messages I could attribute to mmc-spi appear. My suspicion would be that
> it doesn't like the monolithic kernel for some reason (the mmc-spi
> driver registers itself as a driver called "mmc_spi", not sure if the
> modalias handling will catch that; still investigating there).
Right, the modalias needs to be the same as the driver name, not the
module name, so you should change it to mmc_spi as well.
For loading the module it would not make a difference because - and _
are treated the same by the module loader, but the device only
gets associated with the driver when it matches exactly.
> > Then you call that function after registering the master, from
> > mpc52xx_psc_spi_of_probe.
>
> I've changed mpc52xx_psc_spi_do_probe to have an additional argument for
> the OF device node of the SPI master; ARCH=ppc can call this with NULL
> as long as it still exists.
Ok. keeping the code itself in the mpc52xx_psc_spi driver is fine as long
as it's relatively small. Other of_platform_drivers for SPI will just
have to it the same way.
Arnd <><
prev parent reply other threads:[~2008-01-09 21:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-08 14:22 Generic MMC-over-SPI binding? Simon Richter
2008-01-08 16:11 ` Robert Schwebel
2008-01-08 16:29 ` Simon Richter
2008-01-08 17:27 ` Arnd Bergmann
2008-01-09 17:17 ` Simon Richter
2008-01-09 21:55 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801092255.32056.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox