* [PATCH 1/2] [POWERPC] 4xx: Add 405EXr to cputable
@ 2008-01-15 7:09 Stefan Roese
2008-01-15 18:19 ` Scott Wood
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Roese @ 2008-01-15 7:09 UTC (permalink / raw)
To: linuxppc-dev
This patch adds the 405EXr to the powerpc cuptable. Basically the 405EXr
is a 405EX with only one EMAC and only one PCIe interface.
Signed-off-by: Stefan Roese <sr@denx•de>
---
arch/powerpc/kernel/cputable.c | 16 ++++++++++++++--
1 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kernel/cputable.c b/arch/powerpc/kernel/cputable.c
index f1928af..dfb84c8 100644
--- a/arch/powerpc/kernel/cputable.c
+++ b/arch/powerpc/kernel/cputable.c
@@ -1178,8 +1178,8 @@ static struct cpu_spec __initdata cpu_specs[] = {
.platform = "ppc405",
},
{ /* 405EX */
- .pvr_mask = 0xffff0000,
- .pvr_value = 0x12910000,
+ .pvr_mask = 0xffff0004,
+ .pvr_value = 0x12910004,
.cpu_name = "405EX",
.cpu_features = CPU_FTRS_40X,
.cpu_user_features = PPC_FEATURE_32 |
@@ -1189,6 +1189,18 @@ static struct cpu_spec __initdata cpu_specs[] = {
.machine_check = machine_check_4xx,
.platform = "ppc405",
},
+ { /* 405EXr */
+ .pvr_mask = 0xffff0004,
+ .pvr_value = 0x12910000,
+ .cpu_name = "405EXr",
+ .cpu_features = CPU_FTRS_40X,
+ .cpu_user_features = PPC_FEATURE_32 |
+ PPC_FEATURE_HAS_MMU | PPC_FEATURE_HAS_4xxMAC,
+ .icache_bsize = 32,
+ .dcache_bsize = 32,
+ .machine_check = machine_check_4xx,
+ .platform = "ppc405",
+ },
#endif /* CONFIG_40x */
#ifdef CONFIG_44x
--
1.5.4.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] [POWERPC] 4xx: Add 405EXr to cputable
2008-01-15 7:09 [PATCH 1/2] [POWERPC] 4xx: Add 405EXr to cputable Stefan Roese
@ 2008-01-15 18:19 ` Scott Wood
2008-01-15 18:32 ` Olof Johansson
0 siblings, 1 reply; 6+ messages in thread
From: Scott Wood @ 2008-01-15 18:19 UTC (permalink / raw)
To: Stefan Roese; +Cc: linuxppc-dev
On Tue, Jan 15, 2008 at 08:09:15AM +0100, Stefan Roese wrote:
> This patch adds the 405EXr to the powerpc cuptable. Basically the 405EXr
> is a 405EX with only one EMAC and only one PCIe interface.
Sounds like they have the same core... why do they need separate cputable
entries?
-Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] [POWERPC] 4xx: Add 405EXr to cputable
2008-01-15 18:19 ` Scott Wood
@ 2008-01-15 18:32 ` Olof Johansson
2008-01-15 18:25 ` Scott Wood
0 siblings, 1 reply; 6+ messages in thread
From: Olof Johansson @ 2008-01-15 18:32 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev, Stefan Roese
On Tue, Jan 15, 2008 at 12:19:24PM -0600, Scott Wood wrote:
> On Tue, Jan 15, 2008 at 08:09:15AM +0100, Stefan Roese wrote:
> > This patch adds the 405EXr to the powerpc cuptable. Basically the 405EXr
> > is a 405EX with only one EMAC and only one PCIe interface.
>
> Sounds like they have the same core... why do they need separate cputable
> entries?
AMCC has always indicated SoC products by new PVRs. This isn't news,
even though it isn't exactly a clean solution. :)
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] [POWERPC] 4xx: Add 405EXr to cputable
2008-01-15 18:32 ` Olof Johansson
@ 2008-01-15 18:25 ` Scott Wood
2008-01-15 18:38 ` Olof Johansson
0 siblings, 1 reply; 6+ messages in thread
From: Scott Wood @ 2008-01-15 18:25 UTC (permalink / raw)
To: Olof Johansson; +Cc: linuxppc-dev, Stefan Roese
Olof Johansson wrote:
> On Tue, Jan 15, 2008 at 12:19:24PM -0600, Scott Wood wrote:
>> On Tue, Jan 15, 2008 at 08:09:15AM +0100, Stefan Roese wrote:
>>> This patch adds the 405EXr to the powerpc cuptable. Basically the 405EXr
>>> is a 405EX with only one EMAC and only one PCIe interface.
>> Sounds like they have the same core... why do they need separate cputable
>> entries?
>
> AMCC has always indicated SoC products by new PVRs. This isn't news,
> even though it isn't exactly a clean solution. :)
But the old 405EX entry would have matched both chips. Why add a new
significant bit to pvr_mask? For the name in /proc/cpuinfo?
-Scott
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] [POWERPC] 4xx: Add 405EXr to cputable
2008-01-15 18:25 ` Scott Wood
@ 2008-01-15 18:38 ` Olof Johansson
2008-01-15 18:47 ` Josh Boyer
0 siblings, 1 reply; 6+ messages in thread
From: Olof Johansson @ 2008-01-15 18:38 UTC (permalink / raw)
To: Scott Wood; +Cc: linuxppc-dev, Stefan Roese
On Tue, Jan 15, 2008 at 12:25:26PM -0600, Scott Wood wrote:
> Olof Johansson wrote:
> > On Tue, Jan 15, 2008 at 12:19:24PM -0600, Scott Wood wrote:
> >> On Tue, Jan 15, 2008 at 08:09:15AM +0100, Stefan Roese wrote:
> >>> This patch adds the 405EXr to the powerpc cuptable. Basically the 405EXr
> >>> is a 405EX with only one EMAC and only one PCIe interface.
> >> Sounds like they have the same core... why do they need separate cputable
> >> entries?
> >
> > AMCC has always indicated SoC products by new PVRs. This isn't news,
> > even though it isn't exactly a clean solution. :)
>
> But the old 405EX entry would have matched both chips. Why add a new
> significant bit to pvr_mask? For the name in /proc/cpuinfo?
Presumably, yes.
Again, this is nothing new. Other 405/440 products are doing the same
thing.
-Olof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] [POWERPC] 4xx: Add 405EXr to cputable
2008-01-15 18:38 ` Olof Johansson
@ 2008-01-15 18:47 ` Josh Boyer
0 siblings, 0 replies; 6+ messages in thread
From: Josh Boyer @ 2008-01-15 18:47 UTC (permalink / raw)
To: Olof Johansson; +Cc: Scott Wood, linuxppc-dev, Stefan, Roese
On Tue, 15 Jan 2008 12:38:09 -0600
Olof Johansson <olof@lixom•net> wrote:
> On Tue, Jan 15, 2008 at 12:25:26PM -0600, Scott Wood wrote:
> > Olof Johansson wrote:
> > > On Tue, Jan 15, 2008 at 12:19:24PM -0600, Scott Wood wrote:
> > >> On Tue, Jan 15, 2008 at 08:09:15AM +0100, Stefan Roese wrote:
> > >>> This patch adds the 405EXr to the powerpc cuptable. Basically the 405EXr
> > >>> is a 405EX with only one EMAC and only one PCIe interface.
> > >> Sounds like they have the same core... why do they need separate cputable
> > >> entries?
> > >
> > > AMCC has always indicated SoC products by new PVRs. This isn't news,
> > > even though it isn't exactly a clean solution. :)
> >
> > But the old 405EX entry would have matched both chips. Why add a new
> > significant bit to pvr_mask? For the name in /proc/cpuinfo?
>
> Presumably, yes.
>
> Again, this is nothing new. Other 405/440 products are doing the same
> thing.
Does anyone have an actual problem with this patch? I'm inclined to
take it as it doesn't really cause any problems and may eventually be
needed anyway if there is a chip errata or something.
josh
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2008-01-15 18:48 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-01-15 7:09 [PATCH 1/2] [POWERPC] 4xx: Add 405EXr to cputable Stefan Roese
2008-01-15 18:19 ` Scott Wood
2008-01-15 18:32 ` Olof Johansson
2008-01-15 18:25 ` Scott Wood
2008-01-15 18:38 ` Olof Johansson
2008-01-15 18:47 ` Josh Boyer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox