Subject: Re: [PATCH/RFC] [POWERPC] CPM1: implement GPIO LIB API

From: Scott Wood <[email-masked]>
Date: Thu, 17 Jan 2008 12:48:10 -0600

On Thu, Jan 17, 2008 at 03:42:58PM +0100, Jochen Friedrich wrote:
> Hi Grant,
> 
> >>  arch/powerpc/platforms/8xx/Kconfig |    2 +
> >>  arch/powerpc/sysdev/commproc.c     |  162 +++++++++++++++++++++++++++++++++++-
> > 
> > Is this 8xx only?  Can it live in arch/powerpc/platforms/8xx?
> 
> According to the freescale docs, the GPIO ports are part of the CPM1. So I've put the
> support into commproc.c (which maybe should be renamed to cpm1_common.c to match cpm2_common.c).
> 
> AFAIK, CPM1 is specific to 8xx.

If we're going to rename, I'd change commproc.c to cpm1.c, and cpm2_common.c
to cpm2.c.

-Scott