Subject: Re: 2.6.24-rc8-mm1 build failure on headers_check

From: Andrew Morton <[email-masked]>
Date: Thu, 17 Jan 2008 23:38:53 -0800

On Fri, 18 Jan 2008 12:39:51 +0530 Kamalesh Babulal <[email-masked]> wrote:

> Hi Andrew,
> 
> The kernel build fails during the headers_check on power box
> 
>   CHECK   include/asm/nvram.h
> /usr/local/autobench/autotest/tmp/build/linux/usr/include/asm/nvram.h requires linux/list.h, which does not exist in exported headers
> make[3]: *** [/usr/local/autobench/autotest/tmp/build/linux/usr/include/asm/.check.nvram.h] Error 1

doh.

--- a/include/asm-powerpc/nvram.h~include-asm-powerpc-nvramh-needs-listh-fix
+++ a/include/asm-powerpc/nvram.h
@@ -11,7 +11,6 @@
 #define _ASM_POWERPC_NVRAM_H
 
 #include <linux/errno.h>
-#include <linux/list.h>
 
 #define NVRW_CNT 0x20
 #define NVRAM_HEADER_LEN 16 /* sizeof(struct nvram_header) */
@@ -59,6 +58,9 @@ struct nvram_header {
 };
 
 #ifdef __KERNEL__
+
+#include <linux/list.h>
+
 struct nvram_partition {
 	struct list_head partition;
 	struct nvram_header header;
_