From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org
Cc: scottwood@freescale•com, Paul Gortmaker <paul.gortmaker@windriver•com>
Subject: Re: [PATCH] powerpc: reduce code duplication in legacy_serial, add UART parent types
Date: Fri, 25 Jan 2008 07:17:32 +0100 [thread overview]
Message-ID: <200801250717.34309.arnd@arndb.de> (raw)
In-Reply-To: <12011947821738-git-send-email-paul.gortmaker@windriver.com>
On Thursday 24 January 2008, Paul Gortmaker wrote:
> The legacy_serial was treating each UART parent in a separate code block.
> Rather than continue this trend for the new parent IDs, this condenses
> all (soc, tsi, opb, plus two more new types) into one of_device_id array.
> The new types are wrs,epld-localbus for the Wind River sbc8560, and a
> more generic "simple-bus" as requested by Scott Wood.
>=20
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver•com>
Looks good to me, thanks!
=A0
> -=A0=A0=A0=A0=A0=A0=A0/* First fill our array with SOC ports */
> +=A0=A0=A0=A0=A0=A0=A0/* Iterate over all the 16550 ports, looking for kn=
own parents */
> =A0=A0=A0=A0=A0=A0=A0=A0for_each_compatible_node(np, "serial", "ns16550")=
{
> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0struct device_node *soc =3D=
of_get_parent(np);
> -=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (soc && !strcmp(soc->typ=
e, "soc")) {
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0struct device_node *parent =
=3D of_get_parent(np);
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (!parent)
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0con=
tinue;
> +=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0if (of_match_node(parents, =
parent) !=3D NULL) {
Personally, I prefer to write this as
if (of_match_node(parents, parent)) {
but that question of coding style is controversial enough that I
stopped insisting on that, so do whichever you like best.
Arnd <><
next prev parent reply other threads:[~2008-01-25 6:17 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-07 14:25 [PATCH 0/7] Powerpc support for SBC8560 board Paul Gortmaker
[not found] ` <ef7d84e06c45289f51f35845ccaa63bbf31827db.1199715362.git.paul.gortmaker@windriver.com>
2008-01-07 14:25 ` [PATCH 1/7] powerpc: use for_each in legacy_serial Paul Gortmaker
[not found] ` <f6302303b90b7e1516a1f61d85f1eafd51ec3b51.1199715362.git.paul.gortmaker@windriver.com>
2008-01-07 14:25 ` [PATCH 2/7] powerpc: allow localbus compatible serial ports for console device Paul Gortmaker
2008-01-07 14:33 ` Arnd Bergmann
2008-01-07 15:33 ` Paul Gortmaker
2008-01-07 16:04 ` Arnd Bergmann
2008-01-17 22:03 ` Paul Gortmaker
2008-01-17 22:07 ` Scott Wood
2008-01-17 22:35 ` Arnd Bergmann
2008-01-24 17:13 ` [PATCH] powerpc: reduce code duplication in legacy_serial, add UART parent types Paul Gortmaker
2008-01-24 22:40 ` Paul Gortmaker
2008-01-25 8:17 ` Kumar Gala
2008-07-07 6:33 ` Benjamin Herrenschmidt
2008-07-07 15:02 ` Paul Gortmaker
2008-07-07 15:05 ` [PATCH] legacy-serial: more meaningful names, terminate array Paul Gortmaker
2008-07-07 22:17 ` Benjamin Herrenschmidt
2008-07-07 22:42 ` [PATCH] ibmebus: more meaningful variable name Paul Gortmaker
2008-01-25 6:17 ` Arnd Bergmann [this message]
[not found] ` <2e29068028918298af42b5ed07f7db147b81c921.1199715362.git.paul.gortmaker@windriver.com>
2008-01-07 14:25 ` [PATCH 3/7] sbc8560: add support for Wind River SBC8560 in arch/powerpc Paul Gortmaker
2008-01-08 0:32 ` Stephen Rothwell
2008-01-09 4:39 ` Paul Gortmaker
2008-01-09 6:23 ` Stephen Rothwell
[not found] ` <d10d083bafb978936975111f09669120201072ec.1199715362.git.paul.gortmaker@windriver.com>
2008-01-07 14:25 ` [PATCH 4/7] sbc8560: Add device tree source for Wind River SBC8560 board Paul Gortmaker
2008-01-10 2:56 ` David Gibson
2008-01-15 14:12 ` Kumar Gala
2008-01-17 20:50 ` Paul Gortmaker
[not found] ` <51ce902057aacef795405f501ad482c744a2e1f2.1199715362.git.paul.gortmaker@windriver.com>
2008-01-07 14:25 ` [PATCH 5/7] sbc8560: Convert WRS SBC8560 device tree to v1 format Paul Gortmaker
[not found] ` <25caba2d31cd9404db085c69e4d449dabbe56f1f.1199715362.git.paul.gortmaker@windriver.com>
2008-01-07 14:25 ` [PATCH 6/7] CPM2: Make support for the CPM2 optional on 8560 based boards Paul Gortmaker
[not found] ` <20d9f56839785af8a445e4cef3db98430b84b4ce.1199715362.git.paul.gortmaker@windriver.com>
2008-01-07 14:25 ` [PATCH 7/7] sbc8560: Add default .config file for Wind River SBC8560 Paul Gortmaker
2008-01-24 9:30 ` [PATCH 0/7] Powerpc support for SBC8560 board Kumar Gala
2008-01-24 14:17 ` Paul Gortmaker
2008-01-24 14:25 ` Kumar Gala
2008-01-24 14:27 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200801250717.34309.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paul.gortmaker@windriver$(echo .)com \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox