From: Olof Johansson <olof@lixom•net>
To: Greg Kroah-Hartman <gregkh@suse•de>
Cc: linuxppc-dev@ozlabs•org, Kay Sievers <kay.sievers@vrfy•org>,
torvalds@linux-foundation•org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH 063/196] kset: convert /sys/devices to use kset_create
Date: Fri, 25 Jan 2008 21:40:55 -0600 [thread overview]
Message-ID: <20080126034055.GA28786@lixom.net> (raw)
In-Reply-To: <1201245134-4876-63-git-send-email-gregkh@suse.de>
On Thu, Jan 24, 2008 at 11:10:01PM -0800, Greg Kroah-Hartman wrote:
> Dynamically create the kset instead of declaring it statically. We also
> rename devices_subsys to devices_kset to catch all users of the
> variable.
Guess what, you broke powerpc again!
olof@quad:~/work/linux/k.org $ git grep devices_subsys
arch/powerpc/kernel/vio.c:extern struct kset devices_subsys; /* needed for vio_find_name() */
arch/powerpc/kernel/vio.c: found = kset_find_obj(&devices_subsys, kobj_name);
Obviously causes build failues, even of ppc64_defconfig.
(I can unfortunately not boot test, since I lack hardware that uses vio)
Signed-off-by: Olof Johansson <olof@lixom•net>
diff --git a/arch/powerpc/kernel/vio.c b/arch/powerpc/kernel/vio.c
index 19a5656..ee752ab 100644
--- a/arch/powerpc/kernel/vio.c
+++ b/arch/powerpc/kernel/vio.c
@@ -37,7 +37,7 @@
#include <asm/iseries/hv_call_xm.h>
#include <asm/iseries/iommu.h>
-extern struct kset devices_subsys; /* needed for vio_find_name() */
+extern struct kset *devices_kset; /* needed for vio_find_name() */
static struct bus_type vio_bus_type;
@@ -369,7 +369,7 @@ static struct vio_dev *vio_find_name(const char *kobj_name)
{
struct kobject *found;
- found = kset_find_obj(&devices_subsys, kobj_name);
+ found = kset_find_obj(devices_kset, kobj_name);
if (!found)
return NULL;
next parent reply other threads:[~2008-01-26 3:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080125071127.GA4860@kroah.com>
[not found] ` <1201245134-4876-63-git-send-email-gregkh@suse.de>
2008-01-26 3:40 ` Olof Johansson [this message]
2008-01-26 5:24 ` [PATCH 063/196] kset: convert /sys/devices to use kset_create Greg KH
2008-01-26 17:36 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080126034055.GA28786@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=gregkh@suse$(echo .)de \
--cc=kay.sievers@vrfy$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox