Subject: Re: [PATCH] [POWERPC] Xilinx: hwicap driver

From: Nathan Lynch <[email-masked]>
Date: Thu, 31 Jan 2008 23:56:14 -0600

Stephen Neuendorffer wrote:
>
> +static ssize_t
> +hwicap_read(struct file *file, char *buf, size_t count, loff_t *ppos)
> +{
> +	struct hwicap_drvdata *drvdata = file->private_data;
> +	ssize_t bytes_to_read = 0;
> +	u32 *kbuf;
> +	u32 words;
> +	u32 bytes_remaining;
> +	int status;
> +
> +        spin_lock(&hwicap_spinlock);
> +	if (drvdata->is_accessing)
> +		return -EBUSY;

Need to unlock before returning (several places in this patch).