Subject: Re: [RFC][POWERPC] bootwrapper: Add a firmware-independent simpleboot target.

From: David Gibson <[email-masked]>
Date: Fri, 8 Feb 2008 22:02:19 +1100

On Fri, Feb 01, 2008 at 11:55:42PM -0700, Grant Likely wrote:
> From: Grant Likely <[email-masked]>

[snip]
> +void platform_init(unsigned long r3, unsigned long r4, unsigned long r5,
> +		   unsigned long r6, unsigned long r7)
> +{
> +	const u32 *na, *ns, *reg, *timebase;
> +	u64 memsize64;
> +	int node, size, i;
> +
> +	/* Allocate initial heap for probing the tree */
> +	simple_alloc_init(initial_heap, sizeof(initial_heap), 32, 64);
> +
> +	/* Make sure FDT blob is sane */
> +	if (fdt_check_header(_dtb_start) != 0)
> +		fatal("Invalid device tree blob\n");

I think most of these fatal()s are pretty pointless.  This is
platform_init(), so the console won't even have been initialized to
actually print any of the messages.  Precisely because this is
simpleboot, in which every bit of information the wrapper has comes
from teh device tree, if the provided blob is so bad as to fail these
basic tests, we're totally stuffed anyway.  It'll take a hardware
debugger to track down, and I don't think the fatal()s will actually
help much at that point.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson