Subject: Re: [PATCH] [POWERPC] 4xx: Fix Haleakala PCIe compatibility problem in dts

From: Stefan Roese <[email-masked]>
Date: Wed, 20 Feb 2008 14:16:53 +0100

On Wednesday 20 February 2008, Josh Boyer wrote:
> > Since the 4xx PCIe driver checks for 405ex compatibility, the
> > PCIe interface was not detected as it is currently defined as
> > "405exr" compatible. This patch changes it to "405ex".
> >
> > The 405EX and 405EXr are identical exept that the 2nd PCIe and the
> > 2nd EMAC interfaces are missing.
>
> Does ppc405ex_pciex_core_init need to grow some logic to detect 405ex
> from 405exr and return the correct number of ports then?  It
> unconditionally returns 2 today.

Yes, this could be done. Right now it works because the 405EXr board 
(Haleakala) only instantiates one PCIe device in the dts.

A simple solution would be to just do a PVR check. Would this be acceptable?

Best regards,
Stefan