Subject: Re: [patch v8 3/4] USB: add Cypress c67x00 OTG controller HCD driver

From: David Brownell <[email-masked]>
Date: Wed, 20 Feb 2008 19:06:35 -0800

On Wednesday 20 February 2008, Peter Korsgaard wrote:
> +ifeq ($(CONFIG_USB_DEBUG),y)
> +       EXTRA_CFLAGS            += -DDEBUG
> +endif

The canonical Sam Ravnborg comment is to replace that with:

  +ccflags-$(CONFIG_USB_DEBUG)    += -DDEBUG

It's a newish idiom, most easily applied to new code before
it merges ...  :)

> +++ linux-2.6/drivers/usb/host/Kconfig
> @@ -261,3 +261,15 @@
>           To compile this driver as a module, choose M here: the
>           module will be called r8a66597-hcd.
>  
> +config USB_C67X00_HCD
> +       tristate "Cypress C67x00 HCD support"
> +       depends on USB

And I realize that some of the drivers there have violated the
normal "alphabetical order" convention, so maybe one big
cleanup patch would be in order ... but still, I'd rather see
such new options added in the right place, rather than need
to see them fixed up later.

- Dave