Subject: Re: [PATCH 3/5 v3] [POWERPC] Add Canyonlands DTS

From: David Gibson <[email-masked]>
Date: Fri, 22 Feb 2008 12:48:43 +1100

On Thu, Feb 21, 2008 at 03:22:48PM +0100, Stefan Roese wrote:
> Signed-off-by: Stefan Roese <[email-masked]>

[snip]
> +		MAL0: mcmal {
> +			compatible = "ibm,mcmal-460ex", "ibm,mcmal2";
> +			dcr-reg = <180 62>;
> +			num-tx-chans = <2>;
> +			num-rx-chans = <10>;
> +			interrupt-parent = <&MAL0>;
> +			interrupts = <0 1 2 3 4>;
> +			#interrupt-cells = <1>;
> +			#address-cells = <0>;
> +			#size-cells = <0>;
> +			interrupt-map = </*TXEOB*/ 0 &UIC2 6 4
> +					 /*RXEOB*/ 1 &UIC2 7 4
> +					 /*SERR*/  2 &UIC2 3 4
> +					 /*TXDE*/  3 &UIC2 4 4
> +					 /*RXDE*/  4 &UIC2 5 4>;
> +			interrupt-map-mask = <ffffffff>;

Because all the MAL interrupts are on the same UIC, you don't need
this interrupt-map nonsense here - that's just a workaround for the
chips that have the MAL interrupts spread across different UICs.  You
can just use:

	interrupt-parent = <&UIC2>;
	interrupts = <6 4 7 4 3 4 4 4 5 4>;

[snip]
> +			IIC0: i2c@4ef60700 {
> +				device_type = "i2c";

No device_type here.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson