From: "Stephen Neuendorffer" <stephen.neuendorffer@xilinx•com>
To: "Grant Likely" <grant.likely@secretlab•ca>
Cc: linuxppc-dev@ozlabs•org, git-dev <git-dev@xilinx•com>,
jirislaby@gmail•com, linux-kernel@vger•kernel.org
Subject: RE: [PATCH] Xilinx: hwicap: cleanup
Date: Sun, 24 Feb 2008 15:21:49 -0800 [thread overview]
Message-ID: <20080224232152.CEC5F12C8057@mail99-dub.bigfish.com> (raw)
In-Reply-To: <fa686aa40802232216s47b7751bi384352697dbf4ce2@mail.gmail.com>
> -----Original Message-----
> From: glikely@secretlab•ca [mailto:glikely@secretlab•ca] On Behalf Of
Grant Likely
> Sent: Saturday, February 23, 2008 10:17 PM
> To: Stephen Neuendorffer
> Cc: linuxppc-dev@ozlabs•org; git-dev; jirislaby@gmail•com;
linux.kernel@vger•kernel.org
> Subject: Re: [PATCH] Xilinx: hwicap: cleanup
>=20
> On Mon, Feb 11, 2008 at 11:24 AM, Stephen Neuendorffer
> <stephen.neuendorffer@xilinx•com> wrote:
> > Fix some missing __user tags and incorrect section tags.
> > Convert semaphores to mutexes.
> > Make probed_devices re-entrancy and error condition safe.
> > Fix some backwards memcpys.
> > Some other minor cleanups.
> > Use kerneldoc format.
> >
> > Signed-off-by: Stephen Neuendorffer
<stephen.neuendorffer@xilinx•com>
>=20
> Thanks Steven, some more comments below.
>=20
> >
> > ---
> >
> > Grant, Since it appears that the driver will stay in as-is, here
are
> > the updates against mainline, based on Jiri's comments.
> > ---
> > drivers/char/xilinx_hwicap/buffer_icap.c | 80
++++++++++----------
> > drivers/char/xilinx_hwicap/fifo_icap.c | 60 +++++++-------
> > drivers/char/xilinx_hwicap/xilinx_hwicap.c | 113
++++++++++++++++------------
> > drivers/char/xilinx_hwicap/xilinx_hwicap.h | 24 +++---
> > 4 files changed, 148 insertions(+), 129 deletions(-)
> >
> > diff --git a/drivers/char/xilinx_hwicap/buffer_icap.c
b/drivers/char/xilinx_hwicap/buffer_icap.c
> > index dfea2bd..2c5d17d 100644
> > --- a/drivers/char/xilinx_hwicap/buffer_icap.c
> > +++ b/drivers/char/xilinx_hwicap/buffer_icap.c
> > @@ -148,9 +148,9 @@ static inline void buffer_icap_set_size(void
__iomem *base_address,
> > }
> >
> > /**
> > - * buffer_icap_mSetoffsetReg: Set the bram offset register.
> > - * @parameter base_address: contains the base address of the
device.
> > - * @parameter data: is the value to be written to the data
register.
> > + * buffer_icap_mSetoffsetReg - Set the bram offset register.
>=20
> This is the only function that is still in camel case; it should
> probably be changed also... In fact, this functions doesn't seem to be
> used at all. Can it just be removed? Are there any other unused
> functions in this driver?
Actually, it's just the comment that still had the old name.. Fixed it.
-Wall reports one unused static:
drivers/char/xilinx_hwicap/xilinx_hwicap.c:240: warning:
'hwicap_command_capture' defined but not used
I'd intended to leave this in, but I'm thinking it can be done by
userspace code using this driver, so I took it out too.
In verifying this, I discovered that I had inserted a variable names
'register', which doesn't work... Fixed that too.
> > diff --git a/drivers/char/xilinx_hwicap/xilinx_hwicap.c
> b/drivers/char/xilinx_hwicap/xilinx_hwicap.c
> > index 24f6aef..eddaa26 100644
> > --- a/drivers/char/xilinx_hwicap/xilinx_hwicap.c
> > +++ b/drivers/char/xilinx_hwicap/xilinx_hwicap.c
> > @@ -344,7 +345,7 @@ int hwicap_initialize_hwicap(struct
hwicap_drvdata *drvdata)
> > }
> >
> > static ssize_t
> > -hwicap_read(struct file *file, char *buf, size_t count, loff_t
*ppos)
> > +hwicap_read(struct file *file, __user char *buf, size_t count,
loff_t *ppos)
>=20
> This looks like it should be 'char __user *buf' instead of '__user
char *buf'.
Fixed.
=20
> > {
> > struct hwicap_drvdata *drvdata =3D file->private_data;
> > ssize_t bytes_to_read =3D 0;
> > static ssize_t
> > -hwicap_write(struct file *file, const char *buf,
> > +hwicap_write(struct file *file, const __user char *buf,
> > size_t count, loff_t *ppos)
>=20
> Ditto on placement of __user
Fixed.
>=20
> > @@ -549,8 +556,7 @@ static int hwicap_release(struct inode *inode,
struct file *file)
> > int i;
> > int status =3D 0;
> >
> > - if (down_interruptible(&drvdata->sem))
> > - return -ERESTARTSYS;
> > + mutex_lock(&drvdata->sem);
>=20
> Why not mutex_lock_interruptible()? (goes for all cases of
mutex_lock())
It's not clear to me how to get 'correct' behavior in these functions if
the interrupt happens. For instance in probe/setup, if the mutex_lock
is interrupted, it doesn't appear that there is anything to do other
than return an error code that no device is present? I think this was
suggested by Jiri...
Steve
next prev parent reply other threads:[~2008-02-24 23:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1202437061-12691-1-git-send-email-stephen.neuendorffer@xilinx.com>
2008-02-11 18:24 ` [PATCH] Xilinx: hwicap: cleanup Stephen Neuendorffer
2008-02-24 6:16 ` Grant Likely
2008-02-24 6:20 ` Grant Likely
2008-02-24 23:21 ` Stephen Neuendorffer [this message]
2008-02-24 23:34 ` [PATCH] [POWERPC] [v2] " Stephen Neuendorffer
2008-02-27 18:20 ` Grant Likely
2008-02-25 8:16 ` [PATCH] " Jiri Slaby
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080224232152.CEC5F12C8057@mail99-dub.bigfish.com \
--to=stephen.neuendorffer@xilinx$(echo .)com \
--cc=git-dev@xilinx$(echo .)com \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=jirislaby@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox