Subject: Re: [PATCH 3/3] ppc64-specific memory notifier support

From: Nathan Lynch <[email-masked]>
Date: Thu, 28 Feb 2008 11:20:34 -0600

Badari Pulavarty wrote:

> +static struct notifier_block pseries_smp_nb = {

Rename this to pseries_mem_nb?

> +	.notifier_call = pseries_memory_notifier,
> +};
> +
> +static int __init pseries_memory_hotplug_init(void)
> +{
> +	if (firmware_has_feature(FW_FEATURE_LPAR))
> +		pSeries_reconfig_notifier_register(&pseries_smp_nb);
> +
> +	return 0;
> +}
> +arch_initcall(pseries_memory_hotplug_init);

arch_initcall doesn't seem appropriate.  __initcall should be fine.