Subject: Re: [PATCH 2/4] Emerson KSI8560 device tree

From: Scott Wood <[email-masked]>
Date: Thu, 28 Feb 2008 13:12:30 -0600

On Thu, Feb 28, 2008 at 09:47:27PM +0300, Alexandr Smirnov wrote:
> +	soc@fdf00000 {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		device_type = "soc";
> +		ranges = <0x00000000 0xfdf00000 0x00100000>;
> +		reg = <0xfdf00000 0x200>;

The reg property is no longer needed here.

> +		mdio@24520 {					/* For TSECs */
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			device_type = "mdio";
> +			compatible = "gianfar";

No device_type, compatible should be "fsl,gianfar-mdio".

> +	localbus@fdf05000 {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "fsl,mpc8560-localbus";
> +		reg = <0xfdf05000 0x68>;
> +
> +		ranges = <0xe0000000 0xe0000000 0x00800000>;

The localbus node isn't just a container for flash; if you're not going to
use the chipselect mechanism (and you should), then at least use a blank
"ranges;".

> +	cpld@e8080000 {
> +		compatible = "altera,maxii";
> +		reg = <0xe8080000 0x80000>;
> +	};

Should this go under the localbus node?

-Scott