Subject: Re: [PATCH v2] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine

From: Olof Johansson <[email-masked]>
Date: Mon, 17 Mar 2008 19:21:31 -0500

Hi,

On Mon, Mar 17, 2008 at 01:34:05PM -0700, Nelson, Shannon wrote:

> In the future please copy Maciej as one of "the DMA guys" as he has
> taken over ioatdma for me.  Beyond that, one little picky comment
> below...

Time to set up a list, or have everyone monitor lkml, I'd say. I'd
prefer the former.

> >+static unsigned int channels = 4;
> >+module_param(channels, uint, S_IRUGO);
> >+MODULE_PARM_DESC(channels, "Number of channels for copy 
> >(default: 2)");
> 
> Is the number of channels defaulting to 2 or 4?

Ah, yes, good catch.

-Olof