Subject: Re: dtc: Simplify error handling for unparseable input

From: Scott Wood <[email-masked]>
Date: Mon, 24 Mar 2008 12:36:41 -0500

On Mon, Mar 24, 2008 at 02:44:24PM +1100, David Gibson wrote:
> Index: dtc/dtc.h
> ===================================================================
> --- dtc.orig/dtc.h	2008-03-24 14:33:33.000000000 +1100
> +++ dtc/dtc.h	2008-03-24 14:33:34.000000000 +1100
> @@ -232,7 +232,6 @@
>  struct boot_info {
>  	struct reserve_info *reservelist;
>  	struct node *dt;		/* the device tree */
> -	int error;
>  };

If you remove this, there'll be no way to indicate semantic errors other
than die() (the NULL approaches are no good, since they inhibit recovery),
which is suboptimal if the error is not immediately fatal.

-Scott