From: "Xiaochang Duan" <xiaochang.duan@xilinx•com>
To: "Johann Baudy" <johaahn@gmail•com>
Cc: John Linn <linnj@xilinx•com>, git <git@xilinx•com>,
linuxppc-embedded@ozlabs•org
Subject: RE: Xilinx LLTEMAC driver issues
Date: Thu, 3 Apr 2008 11:41:30 -0600 [thread overview]
Message-ID: <20080403174131.F0A54538057@mail176-sin.bigfish.com> (raw)
In-Reply-To: <7e0dd21a0804030939p30699ae3s4c485eb35a53b7ee@mail.gmail.com>
Thanks for the clarification. :)
-Xiaochang
-----Original Message-----
From: Johann Baudy [mailto:johaahn@gmail•com]=20
Sent: Thursday, April 03, 2008 10:39 AM
To: Xiaochang Duan
Cc: MingLiu; John Bonesio; linuxppc-embedded@ozlabs•org; John Linn; git
Subject: Re: Xilinx LLTEMAC driver issues
The only part of the patch that really solves the checksum offload
calculation is into xenet_DmaSend_internal().
The rest is warning removal, comment update and developer friendly =
define :)
Best regards,
Johann
2008/4/3 Xiaochang Duan <xiaochang.duan@xilinx•com>:
>
>
>
>
> According to C operator precedence =
((http://www.difranco.net/cop2220/op-prec.htm), the following patch =
should not be needed as operator "<<" has higher precedence than =
operator "|".
>
>
>
> - XLlDma_mBdWrite((BdPtr), XLLDMA_BD_USR1_OFFSET, (Start) << 16 | =
(Insert))
>
>
> + XLlDma_mBdWrite((BdPtr), XLLDMA_BD_USR1_OFFSET, ((Start) << 16) |
>
> + (Insert))
>
>
>
> Also FYI, the XLlDma_mBdWrite currently is defined in xlldma driver =
as:
>
>
>
> #define XLlDma_mBdWrite(BaseAddress, Offset, Data) \
>
> (*(u32*)((u32)(BaseAddress) + (u32)(Offset)) =3D (Data))
>
>
>
> So I don't understand why the patch could help.
>
>
>
> Thanks,
>
> -Xiaochang
>
> ________________________________
>
> From: MingLiu [mailto:eemingliu@hotmail•com]
> Sent: Thursday, April 03, 2008 2:29 AM
> To: John Bonesio; Johann Baudy
> Cc: linuxppc-embedded@ozlabs•org; John Linn; git
>
> Subject: RE: Xilinx LLTEMAC driver issues
>
>
>
>
>
>
> Dear all,
>
> > The change with the extra parenthesis (in the patch starting with =
line 133) seems unecessary. I looked at the XLlDma_mBdWrite macro and it =
appeared to have the correct use of parethesis in the implementation.
> > So, assuming there's nothing subtle that I missed, it's not needed. =
However, it does no harm either.
>
> However it really helps after I tried this patch. So there should be =
some difference after it is used.
>
> One more question, does this mean that the problem is not on the =
hardware timing, but the device driver?
>
> BR
> Ming
> ________________________________
>
> Windows Live =
Writer=A3=AC=D6=A7=B3=D6=C0=EB=CF=DF=D7=AB=D0=B4=B2=A9=BF=CD=C4=DA=C8=DD=A3=
=AC=CB=E6=CA=B1=CB=E6=B5=D8=CF=EB=D0=B4=BE=CD=D0=B4=A1=A3 =
=C1=A2=BC=B4=CA=B9=D3=C3=A3=A1
--=20
Johann Baudy
johaahn@gmail•com
next prev parent reply other threads:[~2008-04-03 17:41 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080329125416.B09261AD8051@mail119-sin.bigfish.com>
2008-03-29 13:58 ` Xilinx LLTEMAC driver issues John Linn
2008-03-29 14:50 ` Magnus Hjorth
2008-03-30 17:02 ` Stephen Neuendorffer
2008-03-31 9:14 ` rza1
2008-03-31 11:10 ` Magnus Hjorth
2008-04-02 7:20 ` Johann Baudy
2008-04-03 0:31 ` John Bonesio
2008-04-03 8:28 ` MingLiu
2008-04-03 15:42 ` Xiaochang Duan
2008-04-03 16:39 ` Johann Baudy
2008-04-03 17:41 ` Xiaochang Duan [this message]
[not found] ` <BAY138-W323AC0BF7098709A16725DB2F60@phx.gbl>
2008-04-04 9:53 ` Johann Baudy
2008-04-04 10:11 ` MingLiu
2008-04-04 11:54 ` Johann Baudy
2008-03-29 12:54 Magnus Hjorth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080403174131.F0A54538057@mail176-sin.bigfish.com \
--to=xiaochang.duan@xilinx$(echo .)com \
--cc=git@xilinx$(echo .)com \
--cc=johaahn@gmail$(echo .)com \
--cc=linnj@xilinx$(echo .)com \
--cc=linuxppc-embedded@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox