From: Dale Farnsworth <dale@farnsworth•org>
To: Paul Gortmaker <paul.gortmaker@windriver•com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH 1/3] powerpc: Add support for Wind River SBC8641D board
Date: Thu, 10 Apr 2008 18:37:46 -0700 [thread overview]
Message-ID: <20080411013745.GA28655@farnsworth.org> (raw)
In-Reply-To: <0006b107cbf99a968352d9369a8e26304d4bf13a.1207868891.git.paul.gortmaker@windriver.com>
On Thu, Apr 10, 2008 at 07:22:17PM -0400, Paul Gortmaker wrote:
> This adds support for the Wind River SBC8641D board, based
> largely on the mpc86xx_hpcn support. The biggest difference is
> the lack of the Uli and the i8259 cascade, which simplifies things.
Hi Paul,
A couple issues. (These should be fixed in the mpc86xx_hpcn.c as well.)
> +void __init
> +sbc8641_init_irq(void)
Make this function static.
> +void
> +sbc8641_show_cpuinfo(struct seq_file *m)
This one too.
> +static int __init sbc8641_probe(void)
> +{
> + unsigned long root = of_get_flat_dt_root();
> +
> + if (of_flat_dt_is_compatible(root, "mpc86xx"))
"mpc86xx" is too generic. You should make the compatible field
in your devtree something like "WIND,sbc8641d", to differentiate
it from the mpc86xx_hpcn.
> +long __init
> +mpc86xx_time_init(void)
Another static function.
Regards,
-Dale
next prev parent reply other threads:[~2008-04-11 1:37 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 23:22 [PATCH 0/3] Support for Wind River SBC8641D board Paul Gortmaker
2008-04-10 23:22 ` [PATCH 1/3] powerpc: Add support " Paul Gortmaker
2008-04-10 23:22 ` [PATCH 2/3] powerpc: Add device tree source for Wind River SBC8641D Paul Gortmaker
2008-04-10 23:22 ` [PATCH 3/3] powerpc: Add defconfig for Wind River SBC8641D board Paul Gortmaker
2008-04-11 0:05 ` [PATCH 1/3] powerpc: Add support " Stephen Rothwell
2008-04-11 0:38 ` Michael Ellerman
2008-04-11 1:37 ` Dale Farnsworth [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-04-15 22:41 [PATCH 0/3] Support " Paul Gortmaker
2008-04-15 22:41 ` [PATCH 1/3] powerpc: Add support " Paul Gortmaker
2008-04-15 23:21 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080411013745.GA28655@farnsworth.org \
--to=dale@farnsworth$(echo .)org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paul.gortmaker@windriver$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox