From: Andrew Morton <akpm@linux-foundation•org>
To: benh@kernel•crashing.org
Cc: Linux-Arch <linux-arch@vger•kernel.org>,
linuxppc-dev@ozlabs•org, Paul Mackerras <paulus@samba•org>,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH 3/3] Use __weak macro for smp_setup_processor_id
Date: Fri, 18 Apr 2008 01:38:57 -0700 [thread overview]
Message-ID: <20080418013857.92824cfb.akpm@linux-foundation.org> (raw)
In-Reply-To: <1208506747.6958.402.camel@pasglop>
On Fri, 18 Apr 2008 18:19:07 +1000 Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
>
> On Fri, 2008-04-18 at 00:07 -0700, Andrew Morton wrote:
> > On Fri, 18 Apr 2008 16:56:18 +1000 Benjamin Herrenschmidt <benh@kernel•crashing.org> wrote:
> >
> > > Use the __weak macro instead of the longer __attribute__ ((weak)) form
> > >
> > > Signed-off-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> > > --
> > >
> > > init/main.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > --- linux-work.orig/init/main.c 2008-04-18 16:44:32.000000000 +1000
> > > +++ linux-work/init/main.c 2008-04-18 16:44:37.000000000 +1000
> > > @@ -500,7 +500,7 @@ static void __init boot_cpu_init(void)
> > > cpu_set(cpu, cpu_possible_map);
> > > }
> > >
> > > -void __init __attribute__((weak)) smp_setup_processor_id(void)
> > > +void __init __weak smp_setup_processor_id(void)
> > > {
> > > }
> >
> > ack on all three. Please fold #3 into #1 and add both to git-powerpc.
>
> Damn ! I took 5mn to actually split it out in order to not do two
> different things in one patch :-)
ah, I misread it. I thought this was changing the __attribute__((weak))
which patch #1 added. But it's changing a different one. I though that
was odd.
> Will do.
whatever ;)
prev parent reply other threads:[~2008-04-18 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-18 6:56 [PATCH 3/3] Use __weak macro for smp_setup_processor_id Benjamin Herrenschmidt
2008-04-18 7:07 ` Andrew Morton
2008-04-18 8:19 ` Benjamin Herrenschmidt
2008-04-18 8:38 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080418013857.92824cfb.akpm@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox