From: Olof Johansson <olof@lixom•net>
To: Mark Nelson <markn@au1•ibm.com>
Cc: linuxppc-dev@ozlabs•org
Subject: Re: [PATCH] [POWERPC] Add struct iommu_table argument to iommu_map_sg()
Date: Tue, 29 Apr 2008 12:54:17 -0500 [thread overview]
Message-ID: <20080429175413.GA10269@lixom.net> (raw)
In-Reply-To: <4816AF79.502@au1.ibm.com>
On Tue, Apr 29, 2008 at 03:17:45PM +1000, Mark Nelson wrote:
> Make iommu_map_sg take a struct iommu_table. It did so before commit
> 740c3ce66700640a6e6136ff679b067e92125794 (iommu sg merging: ppc: make
> iommu respect the segment size limits).
>
> This stops the function looking in the archdata.dma_data for the iommu
> table because in the future it will be called with a device that has
> no table there.
The logical thing would be to add the archdata.dma_data to said device
instead, no? Without seeing the rest of the code that makes use of it
it's hard to tell anyway, so please post that.
> This also has the nice side effect of making iommu_map_sg() match the
> other map functions.
Consistency is good, but I wonder if the opposite wouldn't be the better
way to go here: always just pass down just the dev pointer instead. The
table can be reached from it.
-Olof
next prev parent reply other threads:[~2008-04-29 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-29 5:17 [PATCH] [POWERPC] Add struct iommu_table argument to iommu_map_sg() Mark Nelson
2008-04-29 17:54 ` Olof Johansson [this message]
2008-04-29 23:53 ` Stephen Rothwell
2008-04-30 0:37 ` Mark Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080429175413.GA10269@lixom.net \
--to=olof@lixom$(echo .)net \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=markn@au1$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox