Subject: Re: [patch 2.6.25-git] spi_mpc83xx much improved driver

From: David Brownell <[email-masked]>
Date: Wed, 30 Apr 2008 15:55:33 -0700

On Wednesday 30 April 2008, Andrew Morton wrote:
> > +     spin_lock_irq(&mpc83xx_spi->lock);
> 
> irq-safe.
> 
> > ...
> >
> > +     spin_lock(&mpc83xx_spi->lock);
> 
> not irq-safe.
> 
> Deliberate?

That latter one is inside an #if 0/#endif block, so it won't matter.
The #if 0 block bothered me.  Maybe Joakim can remove it.

(By the way, I'd feel safer about this patch if there were an
ack or two from more PPC folk...)