From: Mark Nelson <markn@au1•ibm.com>
To: Segher Boessenkool <segher@kernel•crashing.org>
Cc: linuxppc-dev@ozlabs•org, paulus@samba•org
Subject: Re: [PATCH 5/6] [POWERPC] Move device_to_mask() to dma-mapping.h
Date: Fri, 2 May 2008 09:47:47 +1000 [thread overview]
Message-ID: <200805020947.47176.markn@au1.ibm.com> (raw)
In-Reply-To: <742b5895cdf9b898ec2b4834926a41ac@kernel.crashing.org>
On Thu, 1 May 2008 07:04:30 pm Segher Boessenkool wrote:
> > Move device_to_mask() to dma-mapping.h because we need to use it from
> > outside dma_64.c in a later patch.
>
> Why does this need to become an inline function?
>
>
> Segher
>
I'm not sure exactly what you mean - it was inline before the move.
But, I honestly didn't think about it too much (although I possibly should
have)... I figured that it was static inline before my patch so I should leave
it as such.
But if everybody thinks it would be better to leave it in dma_64.c and just
expose it for use outside, I'm fine with that.
Thanks!
Mark.
next prev parent reply other threads:[~2008-05-01 23:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-01 4:29 [PATCH 0/6] [POWERPC] Implement dma_*map*_attrs() and DMA_ATTR_WEAK_ORDERING, use on Cell markn
2008-05-01 4:29 ` [PATCH 1/6] [POWERPC] Add struct iommu_table argument to iommu_map_sg() markn
2008-05-01 4:29 ` [PATCH 2/6] [POWERPC] dma: implement new dma_*map*_attrs() interfaces markn
2008-05-01 4:29 ` [PATCH 3/6] [POWERPC] dma: use the struct dma_attrs in iommu code markn
2008-05-01 4:29 ` [PATCH 4/6] [POWERPC] Make cell_dma_dev_setup_iommu() return the iommu table markn
2008-05-01 4:29 ` [PATCH 5/6] [POWERPC] Move device_to_mask() to dma-mapping.h markn
2008-05-01 9:04 ` Segher Boessenkool
2008-05-01 23:47 ` Mark Nelson [this message]
2008-05-02 0:32 ` Segher Boessenkool
2008-05-02 1:38 ` Mark Nelson
2008-05-01 4:29 ` [PATCH 6/6] [POWERPC] Add DMA_ATTR_WEAK_ORDERING dma attribute and use in Cell IOMMU code markn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200805020947.47176.markn@au1.ibm.com \
--to=markn@au1$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=segher@kernel$(echo .)crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox