From: Anton Vorontsov <avorontsov@ru•mvista.com>
To: Pierre Ossman <drzeus-mmc@drzeus•cx>
Cc: David Brownell <dbrownell@users•sourceforge.net>,
Gary Jennejohn <garyj@denx•de>,
linux-kernel@vger•kernel.org, linuxppc-dev@ozlabs•org,
Guennadi Liakhovetski <g.liakhovetski@gmx•de>
Subject: Re: [RFC PATCH 1/2] mmc_spi: export probe and remove functions
Date: Mon, 26 May 2008 16:25:33 +0400 [thread overview]
Message-ID: <20080526122533.GA9595@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <20080526141836.72db0623@mjolnir.drzeus.cx>
On Mon, May 26, 2008 at 02:18:36PM +0200, Pierre Ossman wrote:
> On Fri, 23 May 2008 22:28:34 +0400
> Anton Vorontsov <avorontsov@ru•mvista.com> wrote:
>
> > ...so we'll able to write bindings for the OpenFirmware without
> > messing with #ifdefs in the driver itself.
> >
> > Signed-off-by: Anton Vorontsov <avorontsov@ru•mvista.com>
>
> This looks extremely wrong. Encapsulating probe functions isn't exactly
> in line with the device model and bound to confuse people.
>
> Your patches doesn't give a complete picture of the OF side of things,
> but can't you solve this by having an init callback somewhere?
Easily, I think this is good (better) idea. Will do.
Thanks,
--
Anton Vorontsov
email: cbouatmailru@gmail•com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2008-05-26 12:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 18:27 [RFC] OpenFirmware bindings for the MMC-over-SPI driver Anton Vorontsov
2008-05-23 18:28 ` [RFC PATCH 1/2] mmc_spi: export probe and remove functions Anton Vorontsov
[not found] ` <20080526141836.72db0623@mjolnir.drzeus.cx>
2008-05-26 12:25 ` Anton Vorontsov [this message]
2008-05-26 13:10 ` Anton Vorontsov
[not found] ` <20080601121841.0392b01c@mjolnir.drzeus.cx>
2008-06-02 12:53 ` Anton Vorontsov
2008-05-23 18:28 ` [RFC PATCH 2/2] mmc: add OpenFirmware bindings for the mmc_spi driver Anton Vorontsov
2008-05-24 2:35 ` Stephen Rothwell
2008-05-26 11:58 ` Anton Vorontsov
2008-05-24 5:19 ` Grant Likely
2008-05-24 14:32 ` Jochen Friedrich
2008-05-24 23:14 ` Segher Boessenkool
2008-05-24 23:06 ` Segher Boessenkool
2008-05-26 11:49 ` Anton Vorontsov
2008-05-26 22:19 ` David Brownell
2008-05-26 23:15 ` Anton Vorontsov
2008-05-24 19:56 ` [RFC] OpenFirmware bindings for the MMC-over-SPI driver David Brownell
2008-05-25 4:47 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080526122533.GA9595@polina.dev.rtsoft.ru \
--to=avorontsov@ru$(echo .)mvista.com \
--cc=dbrownell@users$(echo .)sourceforge.net \
--cc=drzeus-mmc@drzeus$(echo .)cx \
--cc=g.liakhovetski@gmx$(echo .)de \
--cc=garyj@denx$(echo .)de \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox