From: Marc Pignat <marc.pignat@hevs•ch>
To: Anton Vorontsov <avorontsov@ru•mvista.com>
Cc: David Brownell <dbrownell@users•sourceforge.net>,
linux-kernel@vger•kernel.org, linuxppc-dev@ozlabs•org,
spi-devel-general@lists•sourceforge.net,
Timur Tabi <timur@freescale•com>,
Pierre Ossman <drzeus-mmc@drzeus•cx>
Subject: Re: [PATCH 3/3] mmc: change .get_ro() callback semantics
Date: Tue, 3 Jun 2008 12:07:49 +0200 [thread overview]
Message-ID: <200806031207.49843.marc.pignat@hevs.ch> (raw)
In-Reply-To: <20080523154347.GC24862@polina.dev.rtsoft.ru>
Hi all!
On Friday 23 May 2008, Anton Vorontsov wrote:
> get_ro() callback must return values >= 0 for its logical state, and
...
> static void pxamci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
> diff --git a/include/linux/mmc/host.h b/include/linux/mmc/host.h
> index f2e9885..ef3b773 100644
> --- a/include/linux/mmc/host.h
> +++ b/include/linux/mmc/host.h
> @@ -55,6 +55,9 @@ struct mmc_host_ops {
> * Avoid calling these three functions too often or in a "fast path",
> * since underlaying controller might implement them in an expensive
> * and/or slow way.
> + *
> + * .get_ro and .get_cd should return >= 0 for their logical values,
> + * or negative errno value in case of error.
> */
I would suggest to use something more strict (bulletproof), something like:
/*
* get_ro will return:
* 0 for a read/write card
* 1 for a read-only card
* -ENOSYS when not supported
* or a negative errno when something bad happened
*
* get_cd will return:
* 0 for a absent card
* 1 for a present card
* -ENOSYS when not supported
* or a negative errno when something bad happened
*/
I think we have missed one important information: which context these callbacks
can rely on (hard_irq, soft_irq, ...).
Best regards
Marc
next prev parent reply other threads:[~2008-06-03 10:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 16:50 [PATCH 3/4] [MMC] mmc_spi: add polling support for the card detect line Anton Vorontsov
2008-05-17 11:36 ` Pierre Ossman
2008-05-21 18:47 ` Anton Vorontsov
2008-05-21 18:47 ` [PATCH 1/2] mmc: add support for card-detection polling Anton Vorontsov
2008-05-21 18:47 ` [PATCH 2/2] mmc_spi: " Anton Vorontsov
[not found] ` <20080521212831.523f344b@mjolnir.drzeus.cx>
2008-05-22 18:17 ` [PATCH 3/4] [MMC] mmc_spi: add polling support for the card detect line Anton Vorontsov
2008-05-22 18:18 ` [PATCH 1/3] mmc: add support for card-detection polling Anton Vorontsov
2008-05-22 18:18 ` [PATCH 2/3] mmc_spi: " Anton Vorontsov
2008-05-22 18:18 ` [PATCH 3/3] mmc: change .get_ro() callback semantics Anton Vorontsov
[not found] ` <20080522213432.4a50629b@mjolnir.drzeus.cx>
2008-05-23 15:42 ` [PATCH 3/4] [MMC] mmc_spi: add polling support for the card detect line Anton Vorontsov
2008-05-23 15:43 ` [PATCH 1/3] mmc: add support for card-detection polling Anton Vorontsov
2008-05-23 15:43 ` [PATCH 2/3] mmc_spi: " Anton Vorontsov
2008-05-23 15:43 ` [PATCH 3/3] mmc: change .get_ro() callback semantics Anton Vorontsov
2008-06-03 10:07 ` Marc Pignat [this message]
2008-06-05 14:43 ` Anton Vorontsov
2008-06-05 15:58 ` Marc Pignat
2008-06-05 17:10 ` [PATCH] mmc: toughen get_ro() and get_cd() return values Anton Vorontsov
2008-05-19 3:02 ` [PATCH 3/4] [MMC] mmc_spi: add polling support for the card detectline Chen Gong
2008-05-22 12:38 ` Anton Vorontsov
2008-05-22 13:44 ` [PATCH 3/4] [MMC] mmc_spi: add polling support for the carddetectline Chen Gong
2008-05-26 15:37 ` Anton Vorontsov
2008-05-27 2:11 ` [PATCH 3/4] [MMC] mmc_spi: add polling support for thecarddetectline Chen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806031207.49843.marc.pignat@hevs.ch \
--to=marc.pignat@hevs$(echo .)ch \
--cc=avorontsov@ru$(echo .)mvista.com \
--cc=dbrownell@users$(echo .)sourceforge.net \
--cc=drzeus-mmc@drzeus$(echo .)cx \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=spi-devel-general@lists$(echo .)sourceforge.net \
--cc=timur@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox