Subject: Re: [RFC 1/3] hvc_console: rework setup to replace irq functions with callbacks (not word wrapped)

From: Arnd Bergmann <[email-masked]>
Date: Tue, 3 Jun 2008 19:30:09 +0200

On Tuesday 03 June 2008, Christian Borntraeger wrote:

> @@ -42,22 +42,48 @@
>   */
>  #define HVC_ALLOC_TTY_ADAPTERS	8
>  
> +struct hvc_struct {
> +	spinlock_t lock;
> +	int index;
> +	struct tty_struct *tty;
> +	unsigned int count;
> +	int do_wakeup;
> +	char *outbuf;
> +	int outbuf_size;
> +	int n_outbuf;
> +	uint32_t vtermno;
> +	struct hv_ops *ops;
> +	int data;
> +	struct list_head next;
> +	struct kref kref; /* ref count & hvc_struct lifetime */
> +};
>  

I don't see a reason to make this data structure known to other files,
so why not leave it in hvc_console.c?

> +
> +#ifdef CONFIG_HVC_IRQ
> +/* default notifier for irq based notification */
> +extern int notifier_add_irq(struct hvc_struct *hp, int irq);
> +extern void notifier_del_irq(struct hvc_struct *hp, int irq);
> +#endif
>  #endif // HVC_CONSOLE_H

Please remove the #ifdef around the declarations.

h	Arnd <><