From: Anton Vorontsov <avorontsov@ru•mvista.com>
To: Grant Likely <grant.likely@secretlab•ca>
Cc: David Brownell <dbrownell@users•sourceforge.net>,
Gary Jennejohn <garyj@denx•de>,
linux-kernel@vger•kernel.org, linuxppc-dev@ozlabs•org,
Guennadi Liakhovetski <g.liakhovetski@gmx•de>,
Pierre Ossman <drzeus-mmc@drzeus•cx>
Subject: Re: [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver
Date: Thu, 5 Jun 2008 22:31:46 +0400 [thread overview]
Message-ID: <20080605183146.GA29092@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <fa686aa40806051118y39cbf14fye5268c819d4bbbfc@mail.gmail.com>
On Thu, Jun 05, 2008 at 12:18:56PM -0600, Grant Likely wrote:
> On Thu, Jun 5, 2008 at 12:00 PM, Anton Vorontsov
> <avorontsov@ru•mvista.com> wrote:
> > On Thu, Jun 05, 2008 at 11:36:09AM -0600, Grant Likely wrote:
> >> On Thu, Jun 5, 2008 at 11:27 AM, Anton Vorontsov
> >> <avorontsov@ru•mvista.com> wrote:
> >> > Well, I mentioned the usb_add_hcd()-alike approach for the mmc_spi
> >> > host... The absence of enthusiasm I equaled to "no".
> >> >
> >> > Heh.
> >>
> >> I'm allergic to USB HCD code; I was probably having convulsions under my desk.
> >
> > :-)
> >
> > Ok, I also mentioned drivers/ata/pata_of_platform.c (OF version is using
> > common code from drivers/ata/pata_platform.c).
> >
> > Please look there, and tell me if this is what you have in mind. (ignore
> > _probe in the __pata_platform_probe name. Imagine
> > pata_platform_add_controller or something).
>
> Yes, I like that. I've done something very similar for drivers with
> both of and non-of bindings. For another example, this time all
> contained within a single .c file, see drivers/video/xilinxfb.c
Ok, great. As I said previously, this is quite easy to do.
> >> > p.s.
> >> > Btw, you forgot another downside of v2 approach: struct spi_driver
> >> > duplication... Not sure if everyone will be happy about it.
> >> >
> >> > Though, v2 is only version where we can make modular OF_MMC_SPI.
> >>
> >> I think we've got our wires crossed. I'm not referring to the option
> >> of an of_mmc_spi driver registering an mmc_spi device (which can then
> >> be probed by the mmc_spi_driver).
> >
> > I'm not refrering to this option either.
>
> Okay, I'm confused then. Where is the duplication of struct spi_driver?
Here it is http://lkml.org/lkml/2008/5/23/299
+ static struct spi_driver of_mmc_spi_driver = {
And here http://lkml.org/lkml/2008/5/24/153 David Brownell says:
> The only thing that looks odd to me about this is that the wrapper
> is a spi_device rather than an of_device. To me it makes more sense
> to just have an of_device setting up the right spi_device. (Though
> maybe I missed some discussion about why that can't work.)
^^^ That reminds me v1.
Here http://lkml.org/lkml/2008/5/25/5 you answered though, but there
was no bottom line.
I hope the bottom line is that we're now all happy to create another
spi_driver to handle "OF MMC-o-SPI" devices..?
--
Anton Vorontsov
email: cbouatmailru@gmail•com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2008-06-05 18:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-05 16:16 [PATCH] [RFC v3] OF: OpenFirmware bindings for the mmc_spi driver Anton Vorontsov
2008-06-05 16:45 ` Grant Likely
2008-06-05 17:27 ` Anton Vorontsov
2008-06-05 17:36 ` Grant Likely
2008-06-05 18:00 ` Anton Vorontsov
2008-06-05 18:18 ` Grant Likely
2008-06-05 18:31 ` Anton Vorontsov [this message]
2008-06-05 18:42 ` Grant Likely
[not found] ` <20080614175723.209e93dc@mjolnir.drzeus.cx>
2008-06-16 13:23 ` Anton Vorontsov
2008-06-16 14:13 ` Grant Likely
2008-07-03 3:26 ` Jon Smirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080605183146.GA29092@polina.dev.rtsoft.ru \
--to=avorontsov@ru$(echo .)mvista.com \
--cc=dbrownell@users$(echo .)sourceforge.net \
--cc=drzeus-mmc@drzeus$(echo .)cx \
--cc=g.liakhovetski@gmx$(echo .)de \
--cc=garyj@denx$(echo .)de \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox