From: Stephen Neuendorffer <stephen.neuendorffer@xilinx•com>
To: "Grant Likely" <grant.likely@secretlab•ca>
Cc: linuxppc-dev@ozlabs•org, git <git@xilinx•com>, dwg@au1•ibm.com
Subject: RE: [PATCH] [POWERPC] Xilinx: add compatibility for 'simple-bus'.
Date: Fri, 6 Jun 2008 09:16:49 -0700 [thread overview]
Message-ID: <20080606161932.0650C1500054@mail96-sin.bigfish.com> (raw)
In-Reply-To: <fa686aa40806060829h52c5d27fvcec8c02c2eee3c7@mail.gmail.com>
legacy_serial identifies a valid ns16550 on a simple-bus, but the
legacy_serial driver doesn't understand the shift and offset flags
necessary to get it to work, which results in no console.
I think the easiest solution is to change the Kconfig so that
PPC_UDBG_16550 is only selected based on !XILINX_VIRTEX. I've done this
in my tree, but I've been swamped with other things at the moment, so I
haven't verified it.
Or is legacy_serial just legacy at this point and can go away entirely?
I got the impression from some of the earlier discussion that it wasn't
preferred, at least....
Steve
> -----Original Message-----
> From: glikely@secretlab•ca [mailto:glikely@secretlab•ca] On Behalf Of
Grant Likely
> Sent: Friday, June 06, 2008 8:29 AM
> To: Stephen Neuendorffer
> Cc: dwg@au1•ibm.com; jwboyer@linux•vnet.ibm.com;
linuxppc-dev@ozlabs•org; git
> Subject: Re: [PATCH] [POWERPC] Xilinx: add compatibility for
'simple-bus'.
> =
> On Tue, Jun 3, 2008 at 3:41 PM, Stephen Neuendorffer
> <stephen.neuendorffer@xilinx•com> wrote:
> >
> > It appears that this turns out to interact badly with the probing of
> > PPC_UDBG_16550, which is always enabled on PPC405 (and apparently
> > found!) even though Virtex devices don't have them.
> =
> What is the symptom?
> =
> g.
> =
> >
> > Steve
> >
> >> -----Original Message-----
> >> From: Stephen Neuendorffer [mailto:stephen.neuendorffer@xilinx•com]
> >> Sent: Thursday, May 08, 2008 11:25 AM
> >> To: dwg@au1•ibm.com; jwboyer@linux•vnet.ibm.com;
> > grant.likely@secretlab•ca; linuxppc-dev@ozlabs•org
> >> Cc: Stephen Neuendorffer
> >> Subject: [PATCH] [POWERPC] Xilinx: add compatibility for
'simple-bus'.
> >>
> >> ePAPR drafts propose 'simple-bus' as a generic compatibility type
for
> >> busses which cannot be probed for devices. In addition, the Xilinx
> >> versions of these IPs seem to be proliferating. Hence, in the
future
> >> let's prefer to use the standard names. I've left the old names in
> >> for short term backward compatibility for existing device trees.
> >>
> >> Signed-off-by: Stephen Neuendorffer
<stephen.neuendorffer@xilinx•com>
> >> ---
> >> arch/powerpc/platforms/40x/virtex.c | 1 +
> >> 1 files changed, 1 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/arch/powerpc/platforms/40x/virtex.c
> > b/arch/powerpc/platforms/40x/virtex.c
> >> index 6c72994..b1ab7b8 100644
> >> --- a/arch/powerpc/platforms/40x/virtex.c
> >> +++ b/arch/powerpc/platforms/40x/virtex.c
> >> @@ -16,6 +16,7 @@
> >> #include <asm/xilinx_intc.h>
> >>
> >> static struct of_device_id xilinx_of_bus_ids[] __initdata =3D {
> >> + { .compatible =3D "simple-bus", },
> >> { .compatible =3D "xlnx,plb-v46-1.00.a", },
> >> { .compatible =3D "xlnx,plb-v46-1.02.a", },
> >> { .compatible =3D "xlnx,plb-v34-1.01.a", },
> >> --
> >> 1.5.3.4
> =
> --
> Grant Likely, B.Sc., P.Eng.
> Secret Lab Technologies Ltd.
This email and any attachments are intended for the sole use of the named r=
ecipient(s) and contain(s) confidential information that may be proprietary=
, privileged or copyrighted under applicable law. If you are not the intend=
ed recipient, do not read, copy, or forward this email message or any attac=
hments. Delete this email message and any attachments immediately.
next prev parent reply other threads:[~2008-06-06 16:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 20:47 [PATCH] [POWERPC] Xilinx: add compatibility for IBM coreconnect busses Stephen Neuendorffer
2008-05-07 22:33 ` Grant Likely
2008-05-07 22:38 ` Stephen Neuendorffer
2008-05-08 0:18 ` David Gibson
2008-05-08 2:46 ` Josh Boyer
2008-05-08 3:30 ` David Gibson
2008-05-08 11:16 ` Josh Boyer
2008-05-08 16:15 ` [PATCH] [POWERPC] Xilinx: add compatibility for IBMcoreconnect busses Stephen Neuendorffer
2008-05-08 18:25 ` [PATCH] [POWERPC] Xilinx: add compatibility for 'simple-bus' Stephen Neuendorffer
2008-05-08 18:27 ` Grant Likely
[not found] ` <1210271125-11559-1-git-send-email-stephen.neuendorffer@xilinx.com>
2008-06-03 21:41 ` Stephen Neuendorffer
2008-06-06 15:29 ` Grant Likely
2008-06-06 16:16 ` Stephen Neuendorffer [this message]
2008-06-28 20:33 ` Grant Likely
2008-06-30 3:42 ` Stephen Neuendorffer
[not found] ` <977C41F842E66D4CB2E41332313B615019F061@XSJ-EXCHVS1.xlnx.xilinx.com>
2008-06-30 14:39 ` John Linn
[not found] ` <20080630034548.A10A81750069@mail131-sin.bigfish.com>
2008-06-30 16:34 ` Grant Likely
2008-06-30 16:48 ` Stephen Neuendorffer
[not found] ` <977C41F842E66D4CB2E41332313B6150062A27B7@XSJ-EXCHVS1.xlnx.xilinx.com>
2008-06-30 16:49 ` John Linn
2008-07-01 6:16 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080606161932.0650C1500054@mail96-sin.bigfish.com \
--to=stephen.neuendorffer@xilinx$(echo .)com \
--cc=dwg@au1$(echo .)ibm.com \
--cc=git@xilinx$(echo .)com \
--cc=grant.likely@secretlab$(echo .)ca \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox