From: Arnd Bergmann <arnd@arndb•de>
To: linuxppc-dev@ozlabs•org
Cc: Mark Nelson <markn@au1•ibm.com>,
Gunnar von Boehn <VONBOEHN@de•ibm.com>,
cbe-oss-dev@ozlabs•org, Michael Ellerman <ellerman@au1•ibm.com>
Subject: Re: [RFC 1/3] powerpc: __copy_tofrom_user tweaked for Cell
Date: Thu, 19 Jun 2008 16:43:58 +0200 [thread overview]
Message-ID: <200806191643.59037.arnd@arndb.de> (raw)
In-Reply-To: <200806191753.59599.markn@au1.ibm.com>
On Thursday 19 June 2008, Mark Nelson wrote:
> * __copy_tofrom_user routine optimized for CELL-BE-PPC
A few things I noticed:
* You don't have a page wise user copy, which the regular code
has. This is probably not so noticable in iperf, but should
have a significant impact on lmbench and on a number of file
system tests that copy large amounts of data. Have you checked
that the loop around cache lines is just as fast?
* You don't align the source to word size, only the target.
Does this get handled correctly when the source is a noncacheable
mapping, e.g. an unaligned copy_from_user where the source points
to a physical local store mapping of an SPU? I don't think we
need to optimize this case for performance, but I'm not sure
if it would crash. AFAIR, unaligned loads from noncacheable storage
give you an alignment exception that you need to handle, right?
* The naming of the labels (with just numbers) is rather confusing,
it would be good to have something better, but I must admit that
I don't have a good idea either.
* The trick of using the condition code in cr7 for the last bytes
is really cute, but are the four branches actually better than a
single computed branch into the middle of 15 byte wise copies?
Arnd <><
next prev parent reply other threads:[~2008-06-19 14:43 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-19 7:53 [RFC 1/3] powerpc: __copy_tofrom_user tweaked for Cell Mark Nelson
2008-06-19 14:43 ` Arnd Bergmann [this message]
2008-06-19 15:17 ` Gunnar von Boehn
2008-06-19 16:13 ` Sanjay Patel
2008-06-20 11:36 ` Gunnar von Boehn
2008-06-20 17:46 ` Sanjay Patel
2008-06-20 23:20 ` Benjamin Herrenschmidt
2008-06-20 23:44 ` Sanjay Patel
2008-06-23 8:30 ` Gunnar von Boehn
2008-06-23 12:07 ` Geert Uytterhoeven
2008-06-23 23:49 ` Paul Mackerras
2008-06-27 13:30 ` Gunnar von Boehn
2008-06-20 1:13 ` [Cbe-oss-dev] " Paul Mackerras
2008-06-20 16:47 ` Gunnar von Boehn
2008-06-21 2:00 ` Arnd Bergmann
2008-06-21 4:30 ` Paul Mackerras
2008-06-21 4:49 ` David Miller
2008-06-21 21:06 ` Arnd Bergmann
2008-06-20 1:55 ` Mark Nelson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200806191643.59037.arnd@arndb.de \
--to=arnd@arndb$(echo .)de \
--cc=VONBOEHN@de$(echo .)ibm.com \
--cc=cbe-oss-dev@ozlabs$(echo .)org \
--cc=ellerman@au1$(echo .)ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=markn@au1$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox