Subject: Re: [PATCH 58/60] microblaze_v4: sys_microblaze.c

From: Arnd Bergmann <[email-masked]>
Date: Thu, 26 Jun 2008 17:48:29 +0200

On Thursday 26 June 2008, [email-masked] wrote:
> +
> +/*
> + * sys_ipc() is the de-multiplexer for the SysV IPC calls..
> + *
> + * This is really horribly ugly.
> + */

If it's so horribly ugly, don't do it this way ;-)

> +int
> +sys_ipc(uint call, int first, int second, int third, void *ptr, long fifth)
> +{
> +	int version, ret;
> +
> +	version = call >> 16; /* hack for backward compatibility */
> +	call &= 0xffff;

Backwards compatibility with what?

> +static inline unsigned long
> +do_mmap2(unsigned long addr, size_t len,
> +	unsigned long prot, unsigned long flags,
> +	unsigned long fd, unsigned long pgoff)
> +{
> +	struct file *file = NULL;
> +	int ret = -EBADF;
> +
> +	flags &= ~(MAP_EXECUTABLE | MAP_DENYWRITE);
> +	if (!(flags & MAP_ANONYMOUS))
> +		if (!(file = fget(fd))) {
> +			printk(KERN_INFO "no fd in mmap\r\n");
> +			goto out;
> +		}
> +
> +	down_write(&current->mm->mmap_sem);
> +	ret = do_mmap_pgoff(file, addr, len, prot, flags, pgoff);
> +	up_write(&current->mm->mmap_sem);
> +	if (file)
> +		fput(file);
> +out:
> +	return ret;
> +}
> +
> +unsigned long sys_mmap2(unsigned long addr, size_t len,
> +			unsigned long prot, unsigned long flags,
> +			unsigned long fd, unsigned long pgoff)
> +{
> +	return do_mmap2(addr, len, prot, flags, fd, pgoff);
> +}
> +
> +unsigned long sys_mmap(unsigned long addr, size_t len,
> +			unsigned long prot, unsigned long flags,
> +			unsigned long fd, off_t offset)
> +{
> +	int err = -EINVAL;
> +
> +	if (offset & ~PAGE_MASK) {
> +		printk(KERN_INFO "no pagemask in mmap\r\n");
> +		goto out;
> +	}
> +
> +	err = do_mmap2(addr, len, prot, flags, fd, offset >> PAGE_SHIFT);
> +out:
> +	return err;
> +}

Which mmap is uClibc really using? I suppose you only need mmap2, even for
compatibility with any binary ever built for microblaze.

	Arnd <><