Subject: Re: [Resend][PATCH 1/8][Version 2] MPC5121 Update MPC5121ADS device tree

From: Arnd Bergmann <[email-masked]>
Date: Fri, 27 Jun 2008 13:22:52 +0200

On Friday 27 June 2008, John Rigby wrote:
> On Thu, Jun 26, 2008 at 7:42 PM, David Gibson <[email-masked]> wrote:
> >
> > [snip]
> >>       soc@80000000 {
> >>               compatible = "fsl,mpc5121-immr";
> >> +             device_type = "soc";
> >
> > I realise we still need the unwanted device_type value on the soc in
> > some cases for backwards compatibility, but why are you adding it
> > where it wasn't before..?
> >
> Because get_immrbase in fsl_soc.c does not work without it.
> 

I guess that's not much of a problem in the future any more, since with the
move to arch/powerpc, the few remaining drivers that still use it can
finally be converted to use of_iomap on the actual device instead of
the immrbase hack.

	Arnd <><