From: David Gibson <david@gibson•dropbear.id.au>
To: Kumar Gala <galak@kernel•crashing.org>
Cc: Scott Wood <scottwood@freescale•com>, linuxppc-dev@ozlabs•org
Subject: Re: [PATCH v2] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards
Date: Mon, 30 Jun 2008 14:15:25 +1000 [thread overview]
Message-ID: <20080630041525.GD24012@yookeroo.seuss> (raw)
In-Reply-To: <Pine.LNX.4.64.0806271609540.10625@blarg.am.freescale.net>
On Fri, Jun 27, 2008 at 04:10:17PM -0500, Kumar Gala wrote:
> Added DMA nodes for the elo/elo-plus DMA engines.
>
> Renamed the interrupt controller alias in mpc832x_rdb.dts to ipic so that
> its the same as all the other boards.
>
> Signed-off-by: Kumar Gala <galak@kernel•crashing.org>
[snip]
> diff --git a/arch/powerpc/boot/dts/asp834x-redboot.dts b/arch/powerpc/boot/dts/asp834x-redboot.dts
> index 972cf78..8b1bb0e 100644
> --- a/arch/powerpc/boot/dts/asp834x-redboot.dts
> +++ b/arch/powerpc/boot/dts/asp834x-redboot.dts
> @@ -118,6 +118,41 @@
> mode = "cpu";
> };
>
> + dma@82a8 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "fsl,mpc8347-dma", "fsl,elo-dma";
> + reg = <0x82a8 4>;
> + ranges = <0 0x8100 0x1a8>;
> + interrupt-parent = <&ipic>;
> + interrupts = <71 8>;
> + cell-index = <0>;
What's the cell-index in these nodes used to index? Given the
confusion there's been about the proper use of this property, a
comment indicating which shared registers this is used to index is
probably a good idea.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2008-06-30 4:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-27 19:50 [PATCH] powerpc: Add dma nodes to 83xx, 85xx and 86xx boards Kumar Gala
2008-06-27 20:28 ` Scott Wood
2008-06-27 21:08 ` Kumar Gala
2008-06-27 21:10 ` [PATCH v2] " Kumar Gala
2008-06-30 4:15 ` David Gibson [this message]
2008-06-30 15:35 ` Scott Wood
2008-06-30 15:38 ` Kumar Gala
2008-06-30 19:55 ` Scott Wood
2008-06-30 20:56 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080630041525.GD24012@yookeroo.seuss \
--to=david@gibson$(echo .)dropbear.id.au \
--cc=galak@kernel$(echo .)crashing.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=scottwood@freescale$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox