Subject: RE: [PATCH] [POWERPC] Xilinx: add compatibility for 'simple-bus'.

From: John Linn <[email-masked]>
Date: Mon, 30 Jun 2008 08:39:34 -0600

I still have bad dreams about the of_serial patch I did as a newbie
related to reg_shift and reg_offset ;)

I'm still a newbie, but we'll do whatever needs to be done. =

Any thoughts from Josh?

-- John

-----Original Message-----
From: Stephen Neuendorffer =

Sent: Sunday, June 29, 2008 9:42 PM
To: [email-masked]
Cc: [email-masked]; [email-masked];
[email-masked]; git
Subject: RE: [PATCH] [POWERPC] Xilinx: add compatibility for
'simple-bus'.

Is there really much of a chance of that, given the differences with the
bootwrappers?
Does anyone care enough about legacy_serial for this to matter?   My
impression was that legacy serial was not preferred anyway...

Steve

-----Original Message-----
From: [email-masked] on behalf of Grant Likely
Sent: Sat 6/28/2008 1:33 PM
To: Stephen Neuendorffer
Cc: [email-masked]; [email-masked];
[email-masked]; git
Subject: Re: [PATCH] [POWERPC] Xilinx: add compatibility for
'simple-bus'.
 =

On Fri, Jun 6, 2008 at 10:16 AM, Stephen Neuendorffer
<[email-masked]> wrote:
>
> legacy_serial identifies a valid ns16550 on a simple-bus, but the
> legacy_serial driver doesn't understand the shift and offset flags
> necessary to get it to work, which results in no console.
>
> I think the easiest solution is to change the Kconfig so that
> PPC_UDBG_16550 is only selected based on !XILINX_VIRTEX.  I've done
this
> in my tree, but I've been swamped with other things at the moment, so
I
> haven't verified it.

This is an easy solution, but it is not a good one.  Doing so would
break UDBG on other 405 boards when building multiplatform kernels.
It would be better to teach legacy serial about the shift and offset.
Alternately, add code to add_legacy_soc_port() to skip it if the
shift/offset properties are present.

Cheers,
g.

-- =

Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.

This email and any attachments are intended for the sole use of the named r=
ecipient(s) and contain(s) confidential information that may be proprietary=
, privileged or copyrighted under applicable law. If you are not the intend=
ed recipient, do not read, copy, or forward this email message or any attac=
hments. Delete this email message and any attachments immediately.