Subject: Re: [PATCH v2] Add MPC5200B base board mvBC-P

From: Grant Likely <[email-masked]>
Date: Tue, 8 Jul 2008 18:54:09 -0600

On Tue, Jul 08, 2008 at 10:30:00AM +0200, Andre Schwarz wrote:
> David Gibson schrieb:
> > On Mon, Jul 07, 2008 at 10:14:29AM +0200, Andre Schwarz wrote:
> >   
> >> The mvBlueCOUGAR-P is a MPC5200B based camera system with Intel Gigabit ethernet
> >> controller (using e1000). It's just another MPC5200_simple board.
> >>     
> >
> > [snip]
> >   
> >> +		timer@600 {	// General Purpose Timer
> >> +			compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
> >> +			reg = <0x600 0x10>;
> >> +			interrupts = <1 9 0>;
> >> +			interrupt-parent = <&mpc5200_pic>;
> >> +			fsl,has-wdt;
> >> +		};
> >> +
> >> +		timer@610 {	// General Purpose Timer
> >> +			compatible = "fsl,mpc5200b-gpt","fsl,mpc5200-gpt";
> >> +			cell-index = <1>;
> >>     
> >
> > What shared resource is this cell-index value used to index?
> >
> > Also why does it not appear on the timer@600 but does on all the
> > others.
> >
> >   
> Sorry - it's a copy paste problem. At first I only used timer0, i.e.
> this is the original entry.
> After Grant wanting me to have a look at the lite5200b.dts I copied over
> the rest of the dts nodes I also have on my board. On lite5200b.dts the
> cell-index is defined.
> 
> If this is incorrect I'll remove it.
> Is cell-index inappropriate for the timer node ?

Yes, you can drop cell-index for fsl,mpc5200-gpt nodes.

g.