Subject: Re: powerpc/cell/cpufreq: add spu aware cpufreq governor

From: Dave Jones <[email-masked]>
Date: Wed, 9 Jul 2008 02:29:58 -0400

On Wed, Jul 09, 2008 at 03:18:59PM +1000, Ben Herrenschmidt wrote:
 > On Mon, 2008-07-07 at 17:02 +0200, Arnd Bergmann wrote:
 > > From: Christian Krafft <[email-masked]>
 > > 
 > > This patch adds a cpufreq governor that takes the number of running spus
 > > into account. It's very similar to the ondemand governor, but not as complex.
 > > Instead of hacking spu load into the ondemand governor it might be easier to
 > > have cpufreq accepting multiple governors per cpu in future.
 > > Don't know if this is the right way, but it would keep the governors simple.
 > > 
 > > Signed-off-by: Christian Krafft <[email-masked]>
 > > Signed-off-by: Arnd Bergmann <[email-masked]>
 > > ---
 > > 
 > > Dave or other cpufreq people, can you take a look at this
 > > and add an Acked-by when you're happy?
 > > 
 > > We have one prerequisite patch in the powerpc code (in spufs),
 > > so should it get merged through powerpc.git?
 > 
 > Hrm... taking whatever test config I have at hand, applying the patch
 > and doing make oldconfig & make, I get:
 > 
 > ERROR: ".cpufreq_register_governor" [arch/powerpc/platforms/cell/cbe_spu_governor.ko] undefined!
 > ERROR: ".__cpufreq_driver_target" [arch/powerpc/platforms/cell/cbe_spu_governor.ko] undefined!
 > ERROR: ".cpufreq_unregister_governor" [arch/powerpc/platforms/cell/cbe_spu_governor.ko] undefined!
 > ERROR: ".cpufreq_frequency_table_target" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
 > ERROR: ".cpufreq_register_driver" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
 > ERROR: ".cpufreq_frequency_table_verify" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
 > ERROR: ".cpufreq_frequency_table_get_attr" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
 > ERROR: ".cpufreq_notify_transition" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
 > ERROR: ".cpufreq_frequency_table_cpuinfo" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
 > ERROR: ".cpufreq_unregister_driver" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!
 > ERROR: ".cpufreq_frequency_table_put_attr" [arch/powerpc/platforms/cell/cbe-cpufreq.ko] undefined!

Does this help ?

	Dave
 
diff --git a/arch/powerpc/platforms/cell/Kconfig b/arch/powerpc/platforms/cell/Kconfig
index 3959fcf..19f4b4d 100644
--- a/arch/powerpc/platforms/cell/Kconfig
+++ b/arch/powerpc/platforms/cell/Kconfig
@@ -91,6 +91,7 @@ config CBE_THERM
 config CBE_CPUFREQ
 	tristate "CBE frequency scaling"
 	depends on CBE_RAS && CPU_FREQ
+	select CPU_FREQ_TABLE
 	default m
 	help
 	  This adds the cpufreq driver for Cell BE processors.
-- 
http://www.codemonkey.org.uk