From: Mark Brown <broonie@opensource•wolfsonmicro.com>
To: Jon Smirl <jonsmirl@gmail•com>
Cc: linuxppc-dev@ozlabs•org, alsa-devel@alsa-project•org,
liam.girdwood@wolfsonmicro•com
Subject: Re: [alsa-devel] [PATCH v2 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers
Date: Mon, 14 Jul 2008 16:05:28 +0100 [thread overview]
Message-ID: <20080714150527.GD25448@sirena.org.uk> (raw)
In-Reply-To: <9e4733910807140713r5739efedw81e65632006d101d@mail.gmail.com>
On Mon, Jul 14, 2008 at 10:13:14AM -0400, Jon Smirl wrote:
> On 7/14/08, Mark Brown <broonie@opensource•wolfsonmicro.com> wrote:
> > Ideally someone from the PowerPC community would sign off on this -
> > given the nature and volume of discussion people obviously have very
> Grant is one of the core PowerPC developers. There's no big
OK, fair enough...
> Hopefully we can get the driver model sorted out in v2. If the ASoC
> driver model is fixed all of this glue code disappears.
> The PowerPC side isn't without fault too. PowerPC still doesn't have a
> good way to load the fabric/machine driver.
I'm finding it difficult to square these two statements - from an ASoC
point of view the main thing this patch is doing is adding a machine
driver and that's not something that's going to go away. With version 2
you will get the wait for all components to come on-line logic that's
implemented here from the ASoC core but that doesn't remove the need for
a machine driver to tell the core what to wait for and arrange any
machine specific things like clocking. It's this debate about machine
drivers that makes me nervous here.
Like I say, from an ASoC point of view it's not an issue and the current
approach is fine.
> Which are we going to call it, fabric or machine? I had been working
> on the Apple code in sound/aoa. It is called fabric in that code. The
> equivalent driver is called machine in ASoC v1.
ASoC has always called it a machine driver.
> > > This is most likely temporary glue code to work around limitations in
> > > the ASoC v1 framework. I expect ASoC v2 won't need this.
> >
> >
> > It will need some way of providing a machine driver, generic (like this
> > one) or otherwise.
[BTW, it'd be helpful if you could delete unreferenced quotes when you
reply - it makes things much easier to read, especially when reviewing
lengthy patches. Unfortunately the GMail UI encourages doing this :(]
next prev parent reply other threads:[~2008-07-14 15:05 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-12 8:39 [PATCH v2 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers Grant Likely
2008-07-12 8:39 ` [PATCH v2 2/3] ALSA SoC: Add mpc5200-psc I2S driver Grant Likely
2008-07-14 12:10 ` [alsa-devel] " Mark Brown
2008-07-12 8:39 ` [PATCH v2 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver Grant Likely
2008-07-12 18:10 ` [alsa-devel] " Mark Brown
2008-07-12 18:14 ` Grant Likely
2008-07-14 11:45 ` Mark Brown
2008-07-18 6:29 ` Grant Likely
2008-07-18 10:39 ` Mark Brown
2008-07-15 7:57 ` dinesh
2008-07-15 10:33 ` Mark Brown
2008-07-15 12:38 ` dinesh
2008-07-15 12:46 ` Mark Brown
2008-07-16 9:05 ` WRITING AN SOC DRIVER WITHOUT DMA dinesh
2008-07-16 10:07 ` [alsa-devel] " Nobin Mathew
2008-07-16 10:13 ` dinesh
2008-07-17 6:03 ` dinesh
2008-07-17 10:56 ` Mark Brown
2008-07-17 11:26 ` Nobin Mathew
2008-07-17 12:05 ` Jon Smirl
2008-07-17 16:02 ` [PATCH v2 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver Timur Tabi
2008-07-14 13:49 ` [alsa-devel] [PATCH v2 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers Mark Brown
2008-07-14 14:13 ` Jon Smirl
2008-07-14 15:05 ` Mark Brown [this message]
2008-07-14 16:14 ` Timur Tabi
2008-07-14 16:27 ` Grant Likely
2008-07-14 16:53 ` Mark Brown
2008-07-14 17:21 ` Grant Likely
2008-07-14 18:36 ` Mark Brown
2008-07-14 18:40 ` Timur Tabi
2008-07-14 18:49 ` Mark Brown
2008-07-14 18:53 ` Timur Tabi
2008-07-14 22:28 ` Grant Likely
2008-07-14 23:45 ` Jon Smirl
2008-07-15 10:13 ` Mark Brown
2008-07-15 13:08 ` Jon Smirl
2008-07-15 14:04 ` Mark Brown
2008-07-14 15:51 ` Timur Tabi
2008-07-14 17:06 ` Grant Likely
2008-07-14 17:16 ` Mark Brown
2008-07-14 17:22 ` Grant Likely
2008-07-18 7:17 ` Grant Likely
2008-07-18 10:00 ` Mark Brown
2008-07-18 14:59 ` Timur Tabi
2008-07-14 14:16 ` Anton Vorontsov
2008-07-14 17:11 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080714150527.GD25448@sirena.org.uk \
--to=broonie@opensource$(echo .)wolfsonmicro.com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=jonsmirl@gmail$(echo .)com \
--cc=liam.girdwood@wolfsonmicro$(echo .)com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox