From: Andrew Morton <akpm@linux-foundation•org>
To: Matthew Wilcox <matthew@wil•cx>
Cc: linux-arch@vger•kernel.org, linux-ia64@vger•kernel.org,
linux-kernel@vger•kernel.org, linuxppc-dev@ozlabs•org,
Peter Anvin <hpa@zytor•com>,
Linus Torvalds <torvalds@linux-foundation•org>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH] Make u64 long long on all architectures (was: the printk problem)
Date: Tue, 22 Jul 2008 03:05:06 -0700 [thread overview]
Message-ID: <20080722030506.206a2cc2.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080705020350.GN14894@parisc-linux.org>
On Fri, 4 Jul 2008 20:03:51 -0600 Matthew Wilcox <matthew@wil•cx> wrote:
> [PATCH] Make u64 long long on all architectures
>
> It is currently awkward to print a u64 type. Some architectures use
> unsigned long while others use unsigned long long. Since unsigned long
> long is 64-bit for all existing Linux architectures, change those that
> use long to use long long. Note that this applies only within the
> kernel. If u64 is being used in a C++ method definition, the symbol
> mangling would change.
>
> Signed-off-by: Matthew Wilcox <willy@linux•intel.com>
>
> diff --git a/include/asm-generic/int-l64.h b/include/asm-generic/int-l64.h
> index 2af9b75..32f07bd 100644
> --- a/include/asm-generic/int-l64.h
> +++ b/include/asm-generic/int-l64.h
> @@ -23,8 +23,13 @@ typedef unsigned short __u16;
> typedef __signed__ int __s32;
> typedef unsigned int __u32;
>
> +#ifdef __KERNEL__
> +typedef __signed__ long long __s64;
> +typedef unsigned long long __u64;
> +#else
> typedef __signed__ long __s64;
> typedef unsigned long __u64;
> +#endif
>
> #endif /* __ASSEMBLY__ */
This is (IMO) a desirable change and will prevent a heck of a lot of
goofing around, and will permit a lot of prior goofing around to
be removed.
But I bet there are lots of instalces of printk("%l", some_u64) down in
arch code where the type of u64 _is_ known which will now spew warnings.
Oh well.
next prev parent reply other threads:[~2008-07-22 10:05 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080625131101.GA6205@digi.com>
[not found] ` <20080704104634.GA31634@digi.com>
[not found] ` <20080704111540.ddffd241.akpm@linux-foundation.org>
[not found] ` <alpine.LFD.1.10.0807041147450.2815@woody.linux-foundation.org>
2008-07-04 20:02 ` the printk problem Linus Torvalds
2008-07-04 20:27 ` Andrew Morton
2008-07-04 20:41 ` Linus Torvalds
2008-07-04 20:42 ` Matthew Wilcox
2008-07-04 22:01 ` Andrew Morton
2008-07-05 2:03 ` Matthew Wilcox
2008-07-22 10:05 ` Andrew Morton [this message]
2008-07-22 10:36 ` [PATCH] Make u64 long long on all architectures (was: the printk problem) Michael Ellerman
2008-07-22 10:53 ` Andrew Morton
2008-07-22 11:36 ` Benjamin Herrenschmidt
2008-07-22 11:35 ` Benjamin Herrenschmidt
2008-07-05 10:20 ` the printk problem Denys Vlasenko
2008-07-05 11:33 ` Jan Engelhardt
2008-07-05 12:52 ` Vegard Nossum
2008-07-05 13:24 ` Jan Engelhardt
2008-07-05 13:50 ` Vegard Nossum
2008-07-05 14:07 ` Jan Engelhardt
2008-07-05 17:56 ` Linus Torvalds
2008-07-05 18:40 ` Jan Engelhardt
2008-07-05 18:44 ` Linus Torvalds
2008-07-05 18:41 ` Vegard Nossum
2008-07-05 18:52 ` Matthew Wilcox
2008-07-06 0:02 ` Pekka Enberg
2008-07-06 5:17 ` Randy Dunlap
2008-07-04 22:58 ` Benjamin Herrenschmidt
2008-07-04 20:36 ` Matthew Wilcox
2008-07-08 1:44 ` Kyle McMartin
2008-07-04 23:00 ` Benjamin Herrenschmidt
2008-07-04 23:25 ` Linus Torvalds
2008-07-05 22:32 ` Linus Torvalds
2008-07-05 22:57 ` Arjan van de Ven
2008-07-06 5:27 ` Ingo Molnar
2008-07-06 5:37 ` Linus Torvalds
2008-07-06 5:53 ` Ingo Molnar
2008-07-06 6:13 ` Ingo Molnar
2008-07-07 1:14 ` Benjamin Herrenschmidt
2008-07-07 3:26 ` Stephen Rothwell
2008-07-07 3:28 ` Michael Ellerman
2008-07-07 4:59 ` Stephen Rothwell
2008-07-07 3:43 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080722030506.206a2cc2.akpm@linux-foundation.org \
--to=akpm@linux-foundation$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=hpa@zytor$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=matthew@wil$(echo .)cx \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox