Subject: Re: [PATCH 10/16 v3] powerpc: iommu enablement for CMO

From: Robert Jennings <[email-masked]>
Date: Tue, 22 Jul 2008 08:28:17 -0500

* Paul Mackerras ([email-masked]) wrote:
> Robert Jennings writes:
> 
> > To support Cooperative Memory Overcommitment (CMO), we need to check
> > for failure from some of the tce hcalls.
> 
> This patch runs into context mismatches because of changes made by
> Michael Ellerman's patch "Fix sparse warnings in
> arch/powerpc/platforms/pseries" (now in Linus' tree), which changed
> code like
> 
> 	if (condition)
> 		return function_returning_void(args);
> 
> into
> 
> 	if (condition) {
> 		function_returning_void(args);
> 		return;
> 	}
> 
> which will cause problems for your patch.  Please check if any of
> these changes need to be undone again.

I do need to revert those changes, the return values will no longer be
void.  I'll get those tested and posted.  Thanks.

--Rob Jennings