public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab•ca>
To: Jon Smirl <jonsmirl@gmail•com>
Cc: linuxppc-dev@ozlabs•org, alsa-devel@alsa-project•org,
	broonie@opensource•wolfsonmicro.com, timur@freescale•com,
	liam.girdwood@wolfsonmicro•com
Subject: Re: [PATCH v3 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers
Date: Tue, 22 Jul 2008 17:21:58 -0400	[thread overview]
Message-ID: <20080722212158.GB12412@secretlab.ca> (raw)
In-Reply-To: <9e4733910807220938k7452f40co8d51e4b03e79ee8b@mail.gmail.com>

On Tue, Jul 22, 2008 at 12:38:30PM -0400, Jon Smirl wrote:
> On 7/22/08, Grant Likely <grant.likely@secretlab•ca> wrote:
> >  +int of_snd_soc_register_codec(struct snd_soc_codec_device *codec_dev,
> >  +                             void *codec_data, struct snd_soc_dai *dai,
> >  +                             struct device_node *node);
> >  +
> >  +int of_snd_soc_register_platform(struct snd_soc_platform *platform,
> >  +                                struct device_node *node,
> >  +                                struct snd_soc_dai *cpu_dai);
> >  +
> 
> This doesn't compile for me.  Where is struct snd_soc_dai being defined?
> 
> It used to be....
> 
> +int of_snd_soc_register_codec(struct snd_soc_codec_device *codec_dev,
> +			      void *codec_data, struct snd_soc_codec_dai *dai,
> +			      struct device_node *node);
> +
> +int of_snd_soc_register_platform(struct snd_soc_platform *platform,
> +				 struct device_node *node,
> +				 struct snd_soc_cpu_dai *cpu_dai);
> 

I had to change it to match what is in Linus' current top of tree.  The
snd_soc_cpu_dai and snd_soc_codec_dai structures have been merged.

g.

      parent reply	other threads:[~2008-07-22 21:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-22  6:53 [PATCH v3 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers Grant Likely
2008-07-22  6:53 ` [PATCH v3 2/3] ALSA SoC: Add mpc5200-psc I2S driver Grant Likely
2008-07-22 10:09   ` Mark Brown
2008-07-22 21:23     ` Grant Likely
2008-07-22 18:28   ` Jon Smirl
2008-07-22  6:54 ` [PATCH v3 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver Grant Likely
2008-07-22 10:34   ` Mark Brown
2008-07-22  9:27 ` [PATCH v3 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers Mark Brown
2008-07-22 16:38 ` Jon Smirl
2008-07-22 17:51   ` [alsa-devel] " Mark Brown
2008-07-22 21:21   ` Grant Likely [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080722212158.GB12412@secretlab.ca \
    --to=grant.likely@secretlab$(echo .)ca \
    --cc=alsa-devel@alsa-project$(echo .)org \
    --cc=broonie@opensource$(echo .)wolfsonmicro.com \
    --cc=jonsmirl@gmail$(echo .)com \
    --cc=liam.girdwood@wolfsonmicro$(echo .)com \
    --cc=linuxppc-dev@ozlabs$(echo .)org \
    --cc=timur@freescale$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox