Subject: Re: [PATCH 2/6] kvmppc: add hypercall infrastructure - host part

From: Tony Breeds <[email-masked]>
Date: Thu, 24 Jul 2008 11:43:53 +1000

On Wed, Jul 23, 2008 at 10:36:43AM +0200, [email-masked] wrote:
> From: Christian Ehrhardt <[email-masked]>

Hi Christian,
	A few comments 

> diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c
> --- a/arch/powerpc/kvm/emulate.c
> +++ b/arch/powerpc/kvm/emulate.c
> @@ -203,6 +203,24 @@
>  	kvmppc_set_msr(vcpu, vcpu->arch.srr1);
>  }
>  
> +static int kvmppc_do_hypercall(struct kvm_vcpu *vcpu)
> +{
> +	int ret = 0;
> +
> +	switch (vcpu->arch.gpr[0]) {
> +	default:
> +		printk(KERN_ERR"unknown hypercall %d\n", vcpu->arch.gpr[0]);

I think the preffered style is printk(KERN_ERR "...)  You've made the
same style mistake in most of you printk()'s in your other patches
aswell.

Yours Tony

  linux.conf.au    http://www.marchsouth.org/
  Jan 19 - 24 2009 The Australian Linux Technical Conference!