From: Anton Vorontsov <avorontsov@ru•mvista.com>
To: Jon Smirl <jonsmirl@gmail•com>
Cc: ppc-dev <Linuxppc-dev@ozlabs•org>
Subject: Re: Getting GPIO to build again
Date: Thu, 24 Jul 2008 16:08:39 +0400 [thread overview]
Message-ID: <20080724120839.GA24673@polina.dev.rtsoft.ru> (raw)
In-Reply-To: <9e4733910807232034x3af76073x979ef608ddfbebfb@mail.gmail.com>
On Wed, Jul 23, 2008 at 11:34:28PM -0400, Jon Smirl wrote:
> This lets me build again, no clue if it is the correct fix.
No, I don't think that this is correct. OF_GPIO isn't GENERIC_GPIO
provider. GPIO controllers should select GENERIC_GPIO instead.
Though, with this patch:
http://lkml.org/lkml/2008/7/10/269
We'll only have to select ARCH_WANT_OPTIONAL_GPIOLIB. Maybe for whole
powerpc.
> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig
> index 3a7a11a..e14dbe3 100644
> --- a/drivers/of/Kconfig
> +++ b/drivers/of/Kconfig
> @@ -3,6 +3,7 @@ config OF_DEVICE
> depends on OF && (SPARC || PPC_OF)
>
> config OF_GPIO
> + select GENERIC_GPIO
> def_bool y
> depends on OF && PPC_OF && HAVE_GPIO_LIB
> help
>
--
Anton Vorontsov
email: cbouatmailru@gmail•com
irc://irc.freenode.net/bd2
next prev parent reply other threads:[~2008-07-24 12:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-24 3:09 Getting GPIO to build again Jon Smirl
2008-07-24 3:34 ` Jon Smirl
2008-07-24 12:08 ` Anton Vorontsov [this message]
2008-07-24 12:24 ` Jochen Friedrich
2008-07-24 5:08 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080724120839.GA24673@polina.dev.rtsoft.ru \
--to=avorontsov@ru$(echo .)mvista.com \
--cc=Linuxppc-dev@ozlabs$(echo .)org \
--cc=jonsmirl@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox