From: David Gibson <dwg@au1•ibm.com>
To: Jon Tollefson <kniht@linux•vnet.ibm.com>
Cc: npiggin@suse•de, Stephen Rothwell <sfr@canb•auug.org.au>,
ppc-dev <linuxppc-dev@ozlabs•org>,
paulus@samba•org, Andrew Morton <akpm@linux-foundation•org>
Subject: Re: gigantci pages patches
Date: Mon, 28 Jul 2008 11:07:57 +1000 [thread overview]
Message-ID: <20080728010757.GF11318@yookeroo.seuss> (raw)
In-Reply-To: <4886418C.9050704@linux.vnet.ibm.com>
On Tue, Jul 22, 2008 at 03:22:36PM -0500, Jon Tollefson wrote:
> David Gibson wrote:
> > On Fri, Jul 11, 2008 at 05:45:15PM +1000, Stephen Rothwell wrote:
> >
> >> Hi all,
> >>
> >> Could people take one last look at these patches and if there are no
> >> issues, please send Ack-bys to Andrew who will push them to Linus for
> >> 2.6.27.
> >>
> >> [PATCH 1/6 v2] allow arch specific function for allocating gigantic pages
> >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18437
> >> Patch: [PATCH 2/6 v2] powerpc: function for allocating gigantic pages
> >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18438
> >> Patch: [PATCH 3/6 v2] powerpc: scan device tree and save gigantic page locations
> >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18439
> >> Patch: [PATCH 4/6 v2] powerpc: define page support for 16G pages
> >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18440
> >> Patch: [PATCH 5/6 v2] check for overflow
> >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18441
> >> Patch: [PATCH 6/6] powerpc: support multiple huge page sizes
> >> http://patchwork.ozlabs.org/linuxppc/patch?&id=18442
> >>
> >
> > Sorry, I should have looked at these properly when they went past in
> > May, but obviously I missed them.
> >
> > They mostly look ok. I'm a bit confused on 2/6 though - it seems the
> > new powerpc alloc_bootmem_huge_page() function is specific to the 16G
> > gigantic pages. But can't that function also get called for the
> > normal 16M hugepages depending on how the hugepage pool is
> > initialized.
> >
> > Or am I missing something (wouldn't surprise me given my brain's
> > sluggishness today)?
> >
> The alloc_bootmem_huge_page() function is only called for pages >=
> MAX_ORDER. The 16M pages are always allocated within the generic
> hugetlbfs code with alloc_pages_node().
Ah, ok. Well, in that case:
Acked-by: David Gibson <dwg@au1•ibm.com>
for the series.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2008-07-28 1:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-11 7:45 gigantci pages patches Stephen Rothwell
2008-07-22 3:34 ` David Gibson
2008-07-22 20:22 ` Jon Tollefson
2008-07-28 1:07 ` David Gibson [this message]
2008-07-28 3:17 ` Andrew Morton
2008-07-28 3:19 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080728010757.GF11318@yookeroo.seuss \
--to=dwg@au1$(echo .)ibm.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=kniht@linux$(echo .)vnet.ibm.com \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=npiggin@suse$(echo .)de \
--cc=paulus@samba$(echo .)org \
--cc=sfr@canb$(echo .)auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox