From: Vivek Goyal <vgoyal@redhat•com>
To: Simon Horman <horms@verge•net.au>
Cc: Tony Luck <tony.luck@intel•com>,
linux-ia64@vger•kernel.org, kexec@lists•infradead.org,
linux-kernel@vger•kernel.org, linuxppc-dev@ozlabs•org,
Terry Loftin <terry.loftin@hp•com>,
Paul Mundt <lethal@linux-sh•org>,
Paul Mackerras <paulus@samba•org>,
"Eric W. Biederman" <ebiederm@xmission•com>,
Andrew Morton <akpm@linux-foundation•org>,
Linus Torvalds <torvalds@linux-foundation•org>,
Ingo Molnar <mingo@elte•hu>
Subject: Re: [PATCH 3/5] ia64: Define elfcorehdr_addr in arch dependent section
Date: Tue, 29 Jul 2008 09:53:05 -0400 [thread overview]
Message-ID: <20080729135305.GL25975@redhat.com> (raw)
In-Reply-To: <20080729044241.GA23514@verge.net.au>
On Tue, Jul 29, 2008 at 02:42:43PM +1000, Simon Horman wrote:
> On Mon, Jul 28, 2008 at 05:13:14PM -0400, Vivek Goyal wrote:
> >
> > o Move elfcorehdr_addr definition in arch dependent crash dump file. This is
> > equivalent to defining elfcorehdr_addr under CONFIG_CRASH_DUMP instead of
> > CONFIG_PROC_VMCORE. This is needed by is_kdump_kernel() which can be
> > used irrespective of the fact whether CONFIG_PROC_VMCORE is enabled or
> > not.
> >
> > Signed-off-by: Vivek Goyal <vgoyal@redhat•com>
> > ---
> >
> > arch/ia64/kernel/setup.c | 9 ++++++++-
> > 1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff -puN arch/ia64/kernel/setup.c~fix-elfcorehdr_addr-parsing-ia64 arch/ia64/kernel/setup.c
> > --- linux-2.6.27-pre-rc1/arch/ia64/kernel/setup.c~fix-elfcorehdr_addr-parsing-ia64 2008-07-28 12:16:40.000000000 -0400
> > +++ linux-2.6.27-pre-rc1-root/arch/ia64/kernel/setup.c 2008-07-28 12:16:40.000000000 -0400
> > @@ -478,7 +478,12 @@ static __init int setup_nomca(char *s)
> > }
> > early_param("nomca", setup_nomca);
> >
> > -#ifdef CONFIG_PROC_VMCORE
> > +/*
> > + * Note: elfcorehdr_addr is not just limited to vmcore. It is also used by
> > + * is_kdump_kernel() to determine if we are booting after a panic. Hence
> > + * ifdef it under CONFIG_CRASH_DUMP and not CONFIG_PROC_VMCORE.
> > + */
> > +#ifdef CONFIG_CRASH_DUMP
> > /* elfcorehdr= specifies the location of elf core header
> > * stored by the crashed kernel.
> > */
> > @@ -491,7 +496,9 @@ static int __init parse_elfcorehdr(char
> > return 0;
> > }
> > early_param("elfcorehdr", parse_elfcorehdr);
> > +#endif
> >
> > +#ifdef CONFIG_PROC_VMCORE
> > int __init reserve_elfcorehdr(unsigned long *start, unsigned long *end)
> > {
> > unsigned long length;
> > _
>
> Hi Vivek,
>
> I think that you also need the following in arch/ia64/kernel/crash_dump.c.
> With this change your code compiles on ia64.
>
> Signed-off-by: Simon Horman <horms@verge•net.au>
>
>
Thanks Simon. I had done these changes locally but somehow forgot to
include the changes in patches.
I will include these changes in my next posting of consolidated single
patch.
Thanks
Vivek
next prev parent reply other threads:[~2008-07-29 13:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20080727234529.GM6175@verge.net.au>
[not found] ` <20080728015117.GA12055@verge.net.au>
[not found] ` <20080728024526.GB3334@verge.net.au>
[not found] ` <20080728034007.GA30450@verge.net.au>
2008-07-28 21:10 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Vivek Goyal
2008-07-28 21:11 ` [PATCH 2/5] x86: Define elfcorehdr_addr in arch dependent section Vivek Goyal
2008-07-28 21:13 ` [PATCH 3/5] ia64: " Vivek Goyal
2008-07-28 21:14 ` [PATCH 4/5] powerpc: " Vivek Goyal
2008-07-28 21:15 ` [PATCH 5/5] sh: " Vivek Goyal
2008-07-29 14:18 ` Paul Mundt
2008-07-29 4:42 ` [PATCH 3/5] ia64: " Simon Horman
2008-07-29 13:53 ` Vivek Goyal [this message]
2008-07-31 15:29 ` [PATCH 2/5] x86: " Ingo Molnar
2008-07-28 22:37 ` [PATCH 1/5] Move elfcorehdr_addr out of vmcore.c (Was: Re: [patch] crashdump: fix undefined reference to `elfcorehdr_addr') Eric W. Biederman
2008-07-28 22:47 ` Eric W. Biederman
2008-07-29 1:22 ` Simon Horman
2008-07-29 2:28 ` Vivek Goyal
2008-07-29 3:26 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080729135305.GL25975@redhat.com \
--to=vgoyal@redhat$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=ebiederm@xmission$(echo .)com \
--cc=horms@verge$(echo .)net.au \
--cc=kexec@lists$(echo .)infradead.org \
--cc=lethal@linux-sh$(echo .)org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mingo@elte$(echo .)hu \
--cc=paulus@samba$(echo .)org \
--cc=terry.loftin@hp$(echo .)com \
--cc=tony.luck@intel$(echo .)com \
--cc=torvalds@linux-foundation$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox