Subject: Re: [PATCH 1/3] powerpc - Initialize the irq radix tree earlier

From: Sebastien Dugue <[email-masked]>
Date: Tue, 5 Aug 2008 10:27:49 +0200

On Tue, 05 Aug 2008 11:05:03 +1000 Benjamin Herrenschmidt <[email-masked]> wrote:

> 
> >  - Remove the populating of the tree from the revmap function as
> >    you already do
> >  - Move it to irq_create_mapping() for the normal case
> >  - For pre-existing interrupt, have the generic code that initializes
> >    the radix tree walk through all interrupts and setup the revmap for
> >    them. If that needs locking vs. concurrent irq_create_mapping, it's
> >    easy to use one of the available spinlocks for that.
> 
> And in fact, you may even be able to avoid GFP_ATOMIC completely here
> and switch it to GFP_KERNEL since irq_create_mapping() can sleep afaik,
> provided that you avoid the spinlocking.

  Well, maybe, will have to look into this in details.

  Thanks,

  Sebastien.

> Ben.