Subject: Re: [PATCH 6/8] powerpc: set up OF properties for ppc32 kdump

From: Anton Vorontsov <[email-masked]>
Date: Thu, 7 Aug 2008 15:11:56 +0400

On Thu, Aug 07, 2008 at 08:47:31PM +1000, Michael Ellerman wrote:
> On Fri, 2008-08-01 at 18:14 +0400, Anton Vorontsov wrote:
> > From: Dale Farnsworth <[email-masked]>
> > 
> > Refactor the setting of kexec OF properties, moving the common code
> > from machine_kexec_64.c to machine_kexec.c where it can be used on
> > both ppc64 and ppc32.  This will be needed for kdump to work on ppc32
> > platforms.
> 
> Hi Anton,

Hi,

> > diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c
> > index ac42cfb..bfef717 100644
> > --- a/arch/powerpc/kernel/machine_kexec.c
> > +++ b/arch/powerpc/kernel/machine_kexec.c
> > @@ -117,6 +117,7 @@ int overlaps_crashkernel(unsigned long start, unsigned long size)
> >  
> 
> >  static int __init kexec_setup(void)
> >  {
> >  	struct device_node *node;
> > @@ -135,6 +171,8 @@ static int __init kexec_setup(void)
> >  	kernel_end = __pa(_end);
> >  	prom_add_property(node, &kernel_end_prop);
> >  
> > +	export_crashk_values(node);
> > +
> >  	of_node_put(node);
> >  	return 0;
> >  }
> > diff --git a/arch/powerpc/kernel/machine_kexec_64.c b/arch/powerpc/kernel/machine_kexec_64.c
> > index c30678d..2aab296 100644
> > --- a/arch/powerpc/kernel/machine_kexec_64.c
> > +++ b/arch/powerpc/kernel/machine_kexec_64.c
> ...
> 
> > -
> >  static int __init kexec_setup(void)
> >  {
> >  	export_htab_values();
> > -	export_crashk_values();
> >  	return 0;
> >  }
> >  __initcall(kexec_setup);
> 
> This leaves us with two routines called kexec_setup(), do you mind
> getting rid of this one and making export_htab_values() an initcall
> directly.

Yup, good idea. Will do this, and will address your other comments,
too.

Thanks!

-- 
Anton Vorontsov
email: [email-masked]
irc://irc.freenode.net/bd2