Subject: Re: [PATCH] powerpc: Fix Book-E watchdog timer interval setting

From: Matthias Fuchs <[email-masked]>
Date: Thu, 7 Aug 2008 16:04:07 +0200

Sure,

the former line:

 mtspr(SPRN_TCR, (mfspr(SPRN_TCR)&~WDTP(0))|WDTP(booke_wdt_period));

tries to mask the wdt interval period bits by and'ing with ~WDTP(0) which
is 0xffffffff. So no bits are cleared and or'ing a new value does not change anything.
The default interval is '3' which is the maximum, so any attempt to set a new
interval keeps the former '3'.

The patch correctly masks the period bits in SPRN_TCR before writing the new value.

That's all.

Matthias

On Thursday 07 August 2008 15:19, Kumar Gala wrote:
> 
> On Aug 7, 2008, at 7:48 AM, Matthias Fuchs wrote:
> 
> > This patch fixes the setting of the Book-E watchdog timer interval  
> > setup
> > on initialization and by ioctl().
> >
> > Tested on PPC440EPx sequoia evaluation board.
> >
> > Signed-off-by: Matthias Fuchs <[email-masked]>
> > ---
> > drivers/watchdog/booke_wdt.c |    6 +++++-
> > 1 files changed, 5 insertions(+), 1 deletions(-)
> 
> can you be more explicit about what the bug was.
> 
> - k
> 
>