From: Alexander Schmidt <alexs@linux•vnet.ibm.com>
To: Roland Dreier <rolandd@cisco•com>,
"of-ewg" <ewg@lists•openfabrics.org>,
"of-general" <general@lists•openfabrics.org>,
lkml <linux-kernel@vger•kernel.org>,
"linuxppc-dev" <linuxppc-dev@ozlabs•org>
Cc: Joachim Fenkes <fenkes@de•ibm.com>,
Stefan Roscher <stefan.roscher@de•ibm.com>,
Christoph Raisch <raisch@de•ibm.com>
Subject: [PATCH 4/5 try2] ib/ehca: check idr_find() return value
Date: Tue, 12 Aug 2008 15:46:27 +0200 [thread overview]
Message-ID: <200808121546.27705.alexs@linux.vnet.ibm.com> (raw)
The idr_find() function may fail when trying to get the QP that is associated
with a CQE, e.g. when a QP has been destroyed between the generation of a CQE
and the poll request for it. In consequence, the return value of idr_find()
must be checked and the CQE must be discarded when the QP cannot be found.
Signed-off-by: Alexander Schmidt <alexs@linux•vnet.ibm.com>
---
drivers/infiniband/hw/ehca/ehca_reqs.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
--- infiniband.git.orig/drivers/infiniband/hw/ehca/ehca_reqs.c
+++ infiniband.git/drivers/infiniband/hw/ehca/ehca_reqs.c
@@ -680,8 +680,10 @@ repoll:
read_lock(&ehca_qp_idr_lock);
my_qp = idr_find(&ehca_qp_idr, cqe->qp_token);
- wc->qp = &my_qp->ib_qp;
read_unlock(&ehca_qp_idr_lock);
+ if (!my_qp)
+ goto repoll;
+ wc->qp = &my_qp->ib_qp;
wc->byte_len = cqe->nr_bytes_transferred;
wc->pkey_index = cqe->pkey_index;
reply other threads:[~2008-08-12 13:46 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808121546.27705.alexs@linux.vnet.ibm.com \
--to=alexs@linux$(echo .)vnet.ibm.com \
--cc=ewg@lists$(echo .)openfabrics.org \
--cc=fenkes@de$(echo .)ibm.com \
--cc=general@lists$(echo .)openfabrics.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=raisch@de$(echo .)ibm.com \
--cc=rolandd@cisco$(echo .)com \
--cc=stefan.roscher@de$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox